Closed Bug 1806454 Opened 1 year ago Closed 1 year ago

firefox-android: Android-Components tasks are called `release` in the beta graph

Categories

(Release Engineering :: General, enhancement)

enhancement

Tracking

(firefox112 fixed, firefox113 fixed)

RESOLVED FIXED
Tracking Status
firefox112 --- fixed
firefox113 --- fixed

People

(Reporter: jlorenzo, Assigned: gbrown)

References

Details

Attachments

(3 files)

Android-Components beta builds have historically been labeled release because we very introduced beta numbers in the middle of the Android monorepo migration (bug 1800611). In bug 1799696, we added beta focus variants alongside the release Android-Components which is confusing.

Let's make things clearer.

Similarly, we should stop using both build-type and release-type attributes to hold the same type of data. As of now, android-components are labeled by build-type whereas APKs use the release-type attribute.

Assignee: nobody → gbrown

(In reply to Johan Lorenzo [:jlorenzo] from comment #0)

Android-Components beta builds have historically been labeled release

For example, https://firefox-ci-tc.services.mozilla.com/tasks/LWij5kIaT8mSXdjoKwfjjQ/runs/0/logs/public/logs/live.log

[task 2023-03-21T23:17:34.374Z] 2023-03-21 23:17:34,374 - INFO - Creating task with taskId EfVGevaSTHm-KKMg61RiSg for build-components-release-feature-accounts
[task 2023-03-21T23:17:34.377Z] 2023-03-21 23:17:34,377 - INFO - Creating task with taskId Io3sR0m8RW2tTyIj8bRbuw for build-components-release-feature-downloads
[task 2023-03-21T23:17:34.380Z] 2023-03-21 23:17:34,380 - INFO - Creating task with taskId Mf7SZwH9RY6AvH97-a0PDw for build-apk-fenix-beta

Comment on attachment 9326332 [details] [review]
[mozilla-mobile/firefox-android] Bug 1806454 - Rename AC tasks in the beta graphs from 'release' to 'beta' (backport #1464) (#1500)

Beta/Release Uplift Approval Request

  • User impact if declined: No user impact. This is just code cleanup.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky): This patch only affects the mobile task graph, and only on beta. I have tried to thoroughly check the results in simulation but the real "test" is when it hits beta.
  • String changes made/needed: none
  • Is Android affected?: Yes
Attachment #9326332 - Flags: approval-mozilla-beta?
Comment on attachment 9326332 [details] [review]
[mozilla-mobile/firefox-android] Bug 1806454 - Rename AC tasks in the beta graphs from 'release' to 'beta' (backport #1464) (#1500)

Approved for Mobile 112.0 rc1
Attachment #9326332 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: