1806701 - Allow builtin colorways themes to be updated to an AMO hosted theme with the same addon id

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

This issue goal is to allow the builtin colorways themes (which are currently packaged in Firefox itself even when they are expired and not actually visible to the users) to be migrated to AMO hosted themes with the same addon ids, so that the users using expired colorway themes will be migrated to an AMO hosted xpi and we will be able to remove all the expired builtin colorways themes from the tree.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1806701 - Allow builtin colorway themes to be updated to AMO hosted themes with the same addon ids. r?zombie!,dao!

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1806701 - Prevent uninstalling the AMO migrated colorways theme to fallback to the colorways builtin. r?zombie!

Depends on D165194

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1806701 - Add an initial test to cover builtin colorway theme migration to profile installed xpi. r?zombie!

Depends on D165195

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1806701 - Remove migrated colorways themes from the list of the retained themes. r?zombie!,dao!

Depends on D165196

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1806701 - Lock colorways migration behind a pref, disable by default on all channels. r?zombie!,dao

Depends on D165293

Comment 6

[Andreas Wagner [:TheOne] [use NI]]

Luca, could you point me to add-on IDs for these add-ons?

Before this lands, we should make sure that we (Mozilla) own these add-ons on AMO.

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: colorways-themes-list.csv

The attached file is a csv file with the list of the colorways theme ids (and the related collection name for each of them).

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Andreas Wagner [:TheOne] [use NI] from comment #6)

Luca, could you point me to add-on IDs for these add-ons?

Sure thing, I opted to generate it as a csv list and I've just attached it in comment 7.

Comment 9

[Andreas Wagner [:TheOne] [use NI]]

Thank you. Could you also point me to the XPIs, or can we generate them so we can upload them to AMO? The initial version can be whatever is in Firefox right now (or was there last).

Comment 10

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Andreas Wagner [:TheOne] [use NI] from comment #9)

Thank you. Could you also point me to the XPIs, or can we generate them so we can upload them to AMO? The initial version can be whatever is in Firefox right now (or was there last).

In the document that I shared with you earlier today there are links to generated XPI files for both the non-privileged theme version (with removed privileged theme properties and version bump) and the privileged themes as is (plus STR to try both in a nightly build, because the themes that are already expired are not going to be visible by default).

Comment 11

[Andreas Wagner [:TheOne] [use NI]]

Ah, thanks! I will take a look at the document (hadn't seen it yet because I am still digging through email backlog).

Comment 12

[Luca Greco [:rpl] [:luca] [:lgreco]]

Push to try: https://treeherder.mozilla.org/jobs?repo=try&revision=12ae5c7927261e49d325b68035ba76b4a79738a5

Comment 13

[Luca Greco [:rpl] [:luca] [:lgreco]]

With the previous push to try I noticed a windows-only test failure (which was also a test-only issue, the ones that are usually hit in tests that are removing xpi files while technically still in use by the xpcshell test process, which is fine on *nix systems but fails on windows because an error will be thrown then trying to remove a file that is still in use), which should now be fixed (verified locally on a windows box where I was able to reproduce the same failure consistently) by the last small update on D165196.

I'll wait the new push to try to confirm that the test is now passing consistently on windows while running on the build infrastructure (as it did locally on the Windows 10 system I have tried it out):

https://treeherder.mozilla.org/jobs?repo=try&revision=dc5dde9f78f254e4e0a812aa630f10f90f9cfc63

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bb92d5fb953
Allow builtin colorway themes to be updated to AMO hosted themes with the same addon ids. r=zombie,dao
https://hg.mozilla.org/integration/autoland/rev/600af0a5c5e5
Prevent uninstalling the AMO migrated colorways theme to fallback to the colorways builtin. r=zombie
https://hg.mozilla.org/integration/autoland/rev/c2c0ea2c18be
Add an initial test to cover builtin colorway theme migration to profile installed xpi. r=zombie
https://hg.mozilla.org/integration/autoland/rev/ccfa3cf9a6bd
Remove migrated colorways themes from the list of the retained themes. r=zombie,dao
https://hg.mozilla.org/integration/autoland/rev/b27dac0ce1b6
Lock colorways migration behind a pref, disable by default on all channels. r=dao,zombie

Comment 15

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0bb92d5fb953
https://hg.mozilla.org/mozilla-central/rev/600af0a5c5e5
https://hg.mozilla.org/mozilla-central/rev/c2c0ea2c18be
https://hg.mozilla.org/mozilla-central/rev/ccfa3cf9a6bd
https://hg.mozilla.org/mozilla-central/rev/b27dac0ce1b6