1806788 - Update the Element Origin concept for WebDriver BiDi

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The required work for this bug is based on: https://github.com/w3c/webdriver/pull/1653

The current actions code in Marionette needs to be updated to reflect the new concept as to be landed via the above pull request.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

When working on this implementation we should make sure to add tests for inappropriately specifying a Shadow Root as origin to any possible Perform Actions combination. Currently we seem to fail with invalid argument (400): data did not match any variant of untagged enum PointerActionItem at line 1 column 270 because of geckodriver.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

While trying to get this implemented I noticed that we may need slight modifications of the current actions code. But to verify I would need a way to actually work with Elements in WebDriver BiDi. As such we would need bug 1770733 first.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1806788 - [wdspec] Move test_actions_scroll_wdspec.html to shared support folder

Depends on D174912

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1806788 - [wdspec] Port existing WebDriver Classic wheel tests to BiDi

Depends on D175498

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1806788 - [wdspec] Port existing WebDriver Classic wheel tests to BiDi (with get_element_center workaround)

Depends on D175498

Comment 6

[Phabricator Automation]

Comment on attachment 9328582 [details]
Bug 1806788 - [wdspec] Move test_actions_scroll_wdspec.html to shared support folder

Revision D175498 was moved to bug 1806801. Setting attachment 9328582 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9328590 [details]
Bug 1806788 - [wdspec] Port existing WebDriver Classic wheel tests to BiDi (with get_element_center workaround)

Revision D175504 was moved to bug 1806801. Setting attachment 9328590 [details] to obsolete.

Comment 8

[Phabricator Automation]

Comment on attachment 9328587 [details]
Bug 1806788 - [wdspec] Port existing WebDriver Classic wheel tests to BiDi

Revision D175503 was moved to bug 1806801. Setting attachment 9328587 [details] to obsolete.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It would be good to have all the test cases as BiDi tests. Given that this work is currently done via bug 1806801 lets wait for it.

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1806788 - [remote] Support actions using an element origin

Comment 11

[Julian Descottes [:jdescottes]]

Attachment: Bug 1806788 - [wdspec] Fix wrong helper name in bidi pointer_touch.py test

Depends on D177078

Comment 12

[Julian Descottes [:jdescottes]]

Attachment: Bug 1806788 - [wdspec] Fix element origin arguments used for bidi performActions tests

Comment 13

[Julian Descottes [:jdescottes]]

Attachment: Bug 1806788 - [wdspec] Add more tests for invalid origin arguments for bidi perform actions

Depends on D177078

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/665d53d598de
[wdspec] Fix element origin arguments used for bidi performActions tests r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/fa7dde91f5f9
[wdspec] Fix wrong helper name in bidi pointer_touch.py test r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/f085281244af
[remote] Support actions using an element origin r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/2aa5598e5e9b
[wdspec] Add more tests for invalid origin arguments for bidi perform actions r=webdriver-reviewers,jgraham

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39867 for changes under testing/web-platform/tests

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/665d53d598de
https://hg.mozilla.org/mozilla-central/rev/fa7dde91f5f9
https://hg.mozilla.org/mozilla-central/rev/f085281244af
https://hg.mozilla.org/mozilla-central/rev/2aa5598e5e9b

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8395c43e8ab3
[wpt PR 39867] - [Gecko Bug 1806788] [wdspec] Fix element origin arguments used for bidi performActions tests, a=testonly

Comment 19

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8395c43e8ab3

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Actually this is not a visible change for Marionette and for BiDi we had input.performActions as experimental API. As such we don't need this bug in the release notes.