1806794 - Support "network.responseStarted" for cached responses

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Julian Descottes [:jdescottes]]

Handling cached responses for the network.responseStarted event depends on proposed changes for the fetch spec at https://whatpr.org/fetch/1540.html#concept-http-fetch

We have been rediscussing where the trigger should take place for cached response, and most likely this will happen before step 10 of https://whatpr.org/fetch/1540.html#http-network-or-cache-fetch if response is not null

For the initial implementation we will focus on the trigger for non-cached responses (in https://whatpr.org/fetch/1540.html#http-network-fetch)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1806794 - Support "network.response" events for cached responses

This fixes two issues:

• the transferred size was missing from cached responseStarted events
• the fromCache flag needs to be read on the initial network event payload from devtools, because relying on the isFromCache logic used to build the addResponseStart payload does not properly detect all cached responses (eg for a cached 301)

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1806794 - [wdspec] Add wdspec test for cached responseStarted events

Depends on D171508

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02a176fbbb0b
Support "network.response" events for cached responses r=webdriver-reviewers,whimboo,devtools-reviewers,ochameau
https://hg.mozilla.org/integration/autoland/rev/58784e71c915
[wdspec] Add wdspec test for cached responseStarted events r=webdriver-reviewers,whimboo,jgraham
https://hg.mozilla.org/integration/autoland/rev/07ab28076e34
1806802: apply code formatting via Lando

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39030 for changes under testing/web-platform/tests

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/02a176fbbb0b
https://hg.mozilla.org/mozilla-central/rev/58784e71c915
https://hg.mozilla.org/mozilla-central/rev/07ab28076e34

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #4)

Created web-platform-tests PR
https://github.com/web-platform-tests/wpt/pull/39030 for changes under
testing/web-platform/tests

Julian, can you please check the upstream CI checks? Something failed for Chrome and as such the PR cannot be merged.

Comment 7

[Julian Descottes [:jdescottes]]

I restarted the jobs, but I see Azure Pipelines (infrastructure/ tests: macOS) failing on several PRs, maybe there is an infra issue?

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham