1790370 - Implement "network.responseStarted" event

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Comment 1

[Julian Descottes [:jdescottes]]

Let's discuss if we want to keep this in m5, it might be at risk

Comment 2

[Julian Descottes [:jdescottes]]

Removing triage keyword, we are already discussing about when to end the milestone or not.

Comment 3

[Julian Descottes [:jdescottes]]

Hi Valentin,

Question about nsIChannel's protocolVersion. In our current CDP implementation this is what we use to retrieve the protocol used for a given response. I am checking if I could reuse this for our WebDriver BiDi implementation. The specification for the protocol we should expose in our network events is at https://pr-preview.s3.amazonaws.com/w3c/webdriver-bidi/pull/204.html#get-the-protocol , the most important part being:

If response’s final connection timing info is not null, set protocol to response’s final connection timing info's ALPN negotiated protocol.

Does this match nsIChannel protocolVersion? If yes, do you know when we can start reading this on the channel? If not, do you have any suggestion to get the correct value here?

Thanks!

Edit: I should have read the idl first :) it looks like this is pretty self explanatory:

/**
     * Returns the network protocol used to fetch the resource as identified
     * by the ALPN Protocol ID.
     *
     * @throws NS_ERROR_NOT_AVAILABLE if called before the response
     *         has been received (before onStartRequest).
     */
    [must_use] readonly attribute ACString protocolVersion;

but let me know if you have any concern around this nonetheless.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1790370 - [devtools] Expose transferredSize from devtools NetworkObserver

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1790370 - [bidi] Add basic support for network.responseStarted event

Depends on D165431

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1790370 - [wdspec] Add tests for network responseStarted

Depends on D165432

Comment 7

[Valentin Gosu [:valentin] (he/him)]

(In reply to Julian Descottes [:jdescottes] from comment #3)

Does this match nsIChannel protocolVersion? If yes, do you know when we can start reading this on the channel? If not, do you have any suggestion to get the correct value here?

Yes, the timing protocolVersion is the same from nsIChannel.protocolVersion - we set it here

Note that for cached resources, we might report the protocol version used to get the original resource - which I believe is not spec compatible.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cd27b33734e
[devtools] Expose transferredSize from devtools NetworkObserver r=devtools-reviewers,ochameau
https://hg.mozilla.org/integration/autoland/rev/ba47533a1f81
[bidi] Add basic support for network.responseStarted event r=webdriver-reviewers,Sasha,whimboo
https://hg.mozilla.org/integration/autoland/rev/abe601ec2aa5
[wdspec] Add tests for network responseStarted r=webdriver-reviewers,whimboo

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4cd27b33734e
https://hg.mozilla.org/mozilla-central/rev/ba47533a1f81
https://hg.mozilla.org/mozilla-central/rev/abe601ec2aa5

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37803 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham