1806810 - Implement "browsingContext.print" as PDF command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

To get the command added to WebDriver BiDi we can re-use most of the code that is already in use for Marionette and CDP. The whole implementation is already available in a shared module under the remote folder:

https://searchfox.org/mozilla-central/source/remote/shared/PDF.sys.mjs

That means we basically need that new command added to the browsingContext module, and calling the right methods of this shared module.

Note that the specification doesn't include the command yet. The current status can be observed by this issue:

https://github.com/w3c/webdriver-bidi/issues/210

Basic tests should be written, which can mostly be taken from the webdriver classic tests. There will be a follow-up bug to enhance the tests.

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1806810 - [bidi] Implement "browsingContext.print" as PDF command.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1806810 - [wdspec] Add print command to the test client.

Depends on D170353

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1806810 - [wdspec] Add fixtures to load pdf and retrieve pdf content.

Depends on D170354

Comment 4

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1806810 - [wdspec] Add basic tests for "browsingContext.print" command.

Depends on D170355

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8c8789cdc79
[bidi] Implement "browsingContext.print" as PDF command. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/8daae0ae15d2
[wdspec] Add print command to the test client. r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/28ab5735a22e
[wdspec] Add fixtures to load pdf and retrieve pdf content. r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/af0d4dd7a9c2
[wdspec] Add basic tests for "browsingContext.print" command. r=webdriver-reviewers,whimboo

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a8c8789cdc79
https://hg.mozilla.org/mozilla-central/rev/8daae0ae15d2
https://hg.mozilla.org/mozilla-central/rev/28ab5735a22e
https://hg.mozilla.org/mozilla-central/rev/af0d4dd7a9c2

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38902 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2617ff01a809
[wpt PR 38902] - [Gecko Bug 1806810] [wdspec] Add print command to the test client., a=testonly

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2617ff01a809