Closed Bug 1806810 Opened 2 years ago Closed 1 year ago

Implement "browsingContext.print" as PDF command

Categories

(Remote Protocol :: WebDriver BiDi, task, P1)

task
Points:
3

Tracking

(firefox112 fixed)

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

References

(Blocks 2 open bugs, )

Details

(Whiteboard: [webdriver:m6][wptsync upstream][webdriver:relnote])

Attachments

(4 files)

To get the command added to WebDriver BiDi we can re-use most of the code that is already in use for Marionette and CDP. The whole implementation is already available in a shared module under the remote folder:

https://searchfox.org/mozilla-central/source/remote/shared/PDF.sys.mjs

That means we basically need that new command added to the browsingContext module, and calling the right methods of this shared module.

Note that the specification doesn't include the command yet. The current status can be observed by this issue:

https://github.com/w3c/webdriver-bidi/issues/210

Basic tests should be written, which can mostly be taken from the webdriver classic tests. There will be a follow-up bug to enhance the tests.

Blocks: 1806813
Summary: Implement "browsingContext.printToPDF" command → Implement "browsingContext.print" as PDF command
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8c8789cdc79
[bidi] Implement "browsingContext.print" as PDF command. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/8daae0ae15d2
[wdspec] Add print command to the test client. r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/28ab5735a22e
[wdspec] Add fixtures to load pdf and retrieve pdf content. r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/af0d4dd7a9c2
[wdspec] Add basic tests for "browsingContext.print" command. r=webdriver-reviewers,whimboo
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.
Whiteboard: [webdriver:m6] → [webdriver:m6], [wptsync upstream error]
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38902 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m6], [wptsync upstream error] → [webdriver:m6], [wptsync upstream]
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2617ff01a809
[wpt PR 38902] - [Gecko Bug 1806810] [wdspec] Add print command to the test client., a=testonly
Whiteboard: [webdriver:m6], [wptsync upstream] → [webdriver:m6][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: