1806813 - Enhance tests for "browsingContext.print" as PDF command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With bug 1806810 we will get a basic set of tests to make sure that the command works. But we should extend the tests to actually validate the correct output.

James suggested to use pdf.js to verify the output. Mainly because there is already existing code for that purpose. But that would be not cross-browser compliant. So I wonder what other option we would have.

James, any thoughts from your side?

Comment 1

[James Graham [:jgraham]]

It is cross browser; web-platform-tests vendors a copy of pdf.js for this purpose. We already use it in the WebDriver classic tests: https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/print/__init__.py Porting that for BiDi should be more or less trivial.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1806813 - [wdspec] Add fixture to render PDF to png.

Depends on D170356

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1806813 - [wdspec] Enhance tests for "browsingContext.print" as PDF command.

Depends on D171082

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14201ceea9ee
[wdspec] Add fixture to render PDF to png. r=webdriver-reviewers,whimboo,jgraham,jdescottes
https://hg.mozilla.org/integration/autoland/rev/4dfc3d3988f1
[wdspec] Enhance tests for "browsingContext.print" as PDF command. r=webdriver-reviewers,whimboo

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38931 for changes under testing/web-platform/tests

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/14201ceea9ee
https://hg.mozilla.org/mozilla-central/rev/4dfc3d3988f1