1806838 - Extension icons and names duplicate and switch randomly.

Status: REOPENED

(Firefox for Android :: WebExtensions, defect, P3)

Description

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Attachment: Depiction of the problem.

Initial Environment

User Agent: Mozilla/5.0 (Android 13; Mobile; rv:110.0) Gecko/110.0 Firefox/110.0

Steps to reproduce

This occurs when the Add-ons submenu is invoked.

Actual results

Icons and names randomly switch and/or duplicate between the extensions. The attached picture depicts the name of an extension replacing another's.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Kaya [:kaya]]

Can you please verify this bug by testing it on different devices and having large list of addons installed so that you have a scrollable list?

Comment 3

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

[e-mail], I have a lot of addons installed, but can't test on different devices. The issue remains reproducible.

Comment 4

[Andrei Mocirean]

Hello.
I was not able to reproduce the issue on the latest Nightly build (117.0a1) from 18th of July 2023, Beta 116.0b6 nor RC 115.2.1. Could you please tell us if the problem is still present on the latest Nightly available?
Also, if possible, please provide a video regarding the steps to reproduce the issue.

Devices used for testing:

• Google Pixel 7 Pro (Android 14)
• Samsung Galaxy S22 Ultra (Android 13)
• Lenovo Tab P11 Plus (Android 12)

Thanks!

Comment 5

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

[e-mail], I can reproduce it.

Using 117.0a1 (build 2015963299) from 2023-07-20T04:05:51, opening the add-ons menu initially displayed no icons at all, just grey circles. However, when the icons initially loaded, all except for 3 add-ons were correct. The incorrect add-ons were https://addons.mozilla.org/en-GB/firefox/addon/violentmonkey/ and https://addons.mozilla.org/en-US/firefox/addon/universal-trakt-scrobbler/, the latter's icon replacing the former.

I can somewhat relaibly reproduce this specific replacement in this session by simply closing the menu, waiting a minute, and reloading it. If I reopen the menu more quickly, the icons are reordered/deduplicated correctly.

Attached is a screenshot to prove this.

Comment 6

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Attachment: Depiction of the problem.

2023-07-21T01:45:20+01:00

Comment 7

[Jonathan Almeida [:jonalmeida]]

Triage: we want to gauge severity of this bug because we suspect this might happen only when you have a long list of tabs. We can probably use the addons.enabled_addons probe to count how many addons users have installed.

We also suspect, this be related to having a custom addons collection. We would need to fix this bug before general webext availability as well.

Comment 8

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Indeed, both situations usually apply to me.

Comment 9

[Jonathan Almeida [:jonalmeida]]

(In reply to Jonathan Almeida [:jonalmeida] from comment #7)

Triage: we want to gauge severity of this bug because we suspect this might happen only when you have a long list of tabs. We can probably use the addons.enabled_addons probe to count how many addons users have installed.

Post triage: we took a look at our telemetry probes and we have a very small number of users that have more than 1-2 extensions (the largest majority do not use extensions at all).

So if our suspicions are correct, the severity of this bug is correct.

(In reply to Jonathan Almeida [:jonalmeida] from comment #7)

We would need to fix this bug before general webext availability as well.

This still holds true, regardless.

Comment 10

[Arturo Mejia [:amejia]]

We did multiple changes to the Fenix add-on manager and add-ons in general, we would like to confirm if this issue still persist. QA team would you mind helping us to verify?

Thanks in advance!

Comment 11

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

I can't test it currently because I can't install any extensions no matter what I do. Does an issue exist for that?

Comment 12

[Arturo Mejia [:amejia]]

(In reply to third="Beedell", first="Roke", second="Julian Lockhart" from comment #11)

I can't test it currently because I can't install any extensions no matter what I do. Does an issue exist for that?

We don't have a bug filed for it, I tested with the latest Firefox Nightly and I was able to install add-ons, please feel free to file a bug, if the issue persists.

120.0a1 (Build #2015979426), 76b8895043+
GV: 120.0a1-20231011211944
AS: 120.20231011050410

Comment 13

[Alex Cornestean]

I cannot reproduce the issue on the latest Nightly 120.0a1 (Build #2015979618), 9f2286a0f0+, GV: 120.0a1-20231012093726, AS: 120.20231012050441 using an Oppo Reno6 5G running Android 13.

I installed all add-ons present in add-ons manager and added a custom collection as well with https://addons.mozilla.org/en-GB/firefox/addon/violentmonkey/ and https://addons.mozilla.org/en-US/firefox/addon/universal-trakt-scrobbler/, which I also installed. No name duplication or switching occurred.

Closing the issue as Verified Fixed. However, do reopen in case the issue is still reproducible somehow and I missed something.

Comment 14

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Attachment: Reproduction of the issue using Nightly 120.0a1

[e-mail], it's not fixed. I just reproduced the issue.

Comment 15

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Please note that https://bugzilla.mozilla.org/show_bug.cgi?id=1806838#c7 is probably incorrect due to the list being short.

Comment 16

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

By the way, https://bugzilla.mozilla.org/show_bug.cgi?id=1806838#c11 was caused by the recent https://addons.mozilla.org downtime reverting the changes I made to my extension – it occurred about 5 minutes after I saved, so I was just unlucky. All works now in that regard, so I can continue to test this.

Comment 17

[Arturo Mejia [:amejia]]

Hi @{third: "Beedell", first: "Roke"}{.JSON5} ,
We did a major refactor in the way we load extension' icons, we expect this issue is addressed as a result. Would you mind verifying if it's still reproducible for you?

Comment 18

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1806838#c17

[e-mail], has the change been pushed to https://play.google.com/store/apps/details?id=org.mozilla.fenix yet? I'm not going to bother to compile https://github.com/mozilla-mobile/firefox-android/tree/main.

Comment 19

[Arturo Mejia [:amejia]]

The fix should be available from Build #2015983079 and up. This info in available in Settings -> about Firefox Nightly page.

121.0a1 (Build #2015983079), c168513221+
GV: 121.0a1-20231030164930
AS: 121.20231027173509

Comment 20

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Appears to be working, although it always was unpredictable. I'll close until or unless I experience this again.

Comment 21

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

I'll close until or unless I experience this again.

Appears I can't, in retrospect. [e-mail], would you close this as fixed for me (but allow me to retain the ability to reopen it if possible)?

Comment 22

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Attachment: Reproduction of the issue using Nightly 121.0a1 (Build #2015983079), c168513221+

121.0a1 (Build #2015983079), c168513221+
GV: 121.0a1-20231030164930
AS: 121.20231027173509

2023-10-31T04:08:58.555672488

Comment 23

[William Durand [:willdurand]]

Arturo, could you please take another look? Thanks

Comment 24

[eclaudiu64]

I can reproduce this error too, when I have many add-ons installed and when I start the app, I very quickly go to the list of add-ons it shows in the 3 dot menu and it shows that the add-on icons are duplicated.

Comment 25

[eclaudiu64]

Attachment: mobizen_20231218_170016.mp4

It can be reproduced by opening.

Comment 26

[eclaudiu64]

Attachment: mobizen_20231218_172355_001_001.mp4

It can also reproduce when I switch tabs in the address bar.

Comment 27

[eclaudiu64]

(In reply to eclaudiu64 from comment #25)

Created attachment 9369212 [details]
mobizen_20231218_170016.mp4

It can be reproduced by opening.

I can also reproduce when I leave Firefox in the background and exit the app and then re-enter Firefox.

Comment 28

[Arturo Mejia [:amejia]]

(In reply to William Durand [:willdurand] from comment #23)

Arturo, could you please take another look? Thanks

Sure!

Comment 29

[Arturo Mejia [:amejia]]

Hi {third: "Beedell", first: "Roke"} and eclaudiu64,
I'm having a really hard time trying to reproduce the bug, would you mind sharing the devices and models which are testing?

Thanks in advance!

Comment 30

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Attachment: Reproduction of the issue using Nightly 122.0a1 (Build #2015992295)

https://bugzilla.mozilla.org/show_bug.cgi?id=1806838#c29

[e-mail], I am using a Fairphone FP4 running its stock AOSP-derived OS (specifically build FP4.TP1X.C.079.20231013, not 073) installed originally via adb but updated OTA, so it should match vendor installations entirely. I use Firefox Nigtly build #2015992295 from commit 7a2b8bdcde+ at 2023-12-18T04:06:13.890921567, all according to its About (always nice to be proper ISO 8601 date formatting :D). To confirm, the bug is constantly reproducible now for me on this build.

Comment 31

[Arturo Mejia [:amejia]]

Thanks for the info, would you mind also sharing the adb logs when the issue happens, you could start capturing when opening the app until you experience the issue.

Thanks in advance!

Comment 32

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1806838#c31

[e-mail], I'll certainly try. However, although I've not used logcat before now, owing to https://github.com/mozilla-mobile/firefox-android/blob/main/fenix/docs/Logging-Crash-Information.md#:~:text=logcat%20to%20get-,crash%20information,-Please%20use%20the, does it record more than crash information, at least without any Developer Mode (com.android.settings) preferences enabled to increase verbosity?

Comment 33

[Arturo Mejia [:amejia]]

does it record more than crash information?

Yes, it should record any logs from an Android device :) .

at least without any Developer Mode (com.android.settings) preferences enabled to increase verbosity?

I think for adb to recognize your device you will need to enable the Developer Mode, this guide could be help even if it's mentioning crashes, adb should capture any Android logs.

If you need extra help don't hesitate to ask!

Comment 34

[Arturo Mejia [:amejia]]

If you don't mind @emanuellclaudiu, could you also provide adb logs?

Thanks in advance!

Comment 35

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1806838#c33

1. I think for adb to recognize your device you will need to enable the Developer Mode, this guide could be help even if it's mentioning crashes, adb should capture any Android logs.

   Haha, I'm aware of that. Thanks though. I meant, for instance, whether you wanted verbose vendor logging, but it appears that the A13 update has removed my ability to enable it. Regardless, would a System Trace or standard Bug Report also be useful? (I'm only hounding you with these questions because I can't capture logcat for the next half hour or so while I'm doing something, so I might as well do it properly).

2. If you need extra help don't hesitate to ask!

   Thank you.

Comment 36

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1806838#c34

(Did that send late?)

Comment 37

[eclaudiu64]

(In reply to Arturo Mejia [:amejia] from comment #34)

If you don't mind @emanuellclaudiu, could you also provide adb logs?

Thanks in advance!

Unfortunately, I don't have any crashes in the recorded list, I reinstalled Firefox Nightly. And when this error happens no error is logged.

Comment 38

[eclaudiu64]

(In reply to Arturo Mejia [:amejia] from comment #29)

Hi {third: "Beedell", first: "Roke"} and eclaudiu64,
I'm having a really hard time trying to reproduce the bug, would you mind sharing the devices and models which are testing?

Thanks in advance!

The phone models that can clone are Moto G82 5G, Moto E7 Plus and a Samsung A20E, android versions 10, 11 and 13. For reproduction I used the address bar at the top, maybe that's how you can reproduce the error.

Comment 39

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Attachment: logcat during bug

The last 400 or so lines from the end are actually useful. I seriously doubt the rest is - it took a while to reproduce the bug.

I had to remove a significant portion of the middle section (approximately 8 MiB) because https://gist.github.com/ and https://gitlab.com/-/snippets/new both refused to upload the data, and a limit of 10 MiB exists here.

Comment 40

[Arturo Mejia [:amejia]]

Thanks for all the details I think I was able to reproduce!
I'll update the bug with further details when we figure out the root cause.

Comment 41

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Attachment: AOSP "Bug Report"

https://bugzilla.mozilla.org/show_bug.cgi?id=1806838#c39

In case it's of any use, I also did a standard bug report at the same moment I halted the logcat.

Comment 42

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1806838 - Update extension icon when invalidate is called. (#4928)

Comment 43

[BMO Github Automation]

Authored by https://github.com/Amejia481
https://github.com/mozilla-mobile/firefox-android/commit/4b22b175910e0ece64650b76be6e4d5fe54b7472
[main] Bug 1806838 - Update extension icon when invalidate is called.

Comment 44

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:amejia, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.

Comment 45

[Arturo Mejia [:amejia]]

Hello {third: "Beedell", first: "Roke"}{.JSON5} and eclaudiu64,
We landed a new a patch, that should address the issue it should be available in the incoming Firefox Nightly updates.
When you have some time, would you mind giving it a try?

Thanks in advance!

Comment 46

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1806838#c45

[e-mail], do you know what version (or commit listed in About, whatever I need to look for) of Nightly this shall land in? I don't compile this myself — I use the compiled versions published to Google Play to test.

Comment 47

[eclaudiu64]

(In reply to Arturo Mejia [:amejia] from comment #45)

For the latest version of Firefox Nightly, from the Play Store, I notice that this error has been resolved.

Comment 48

[Arturo Mejia [:amejia]]

Sorry for the delay, by now the change should be on the any of the latest versions of Firefox nightly offered on the Google Play store.

Comment 49

[Donal Meehan [:dmeehan]]

:amejia could you take a look at Comment 44?
Is this safe for you to add an uplift request, or should it ride the train with Fx123?

Comment 50

[Arturo Mejia [:amejia]]

As this is not a high priority ticket, we prefer to just ride the trains so we have more time to confirm that is addressed.

Comment 52

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Attachment: Screenshot_20240815-130319.png

This recently recurred. I don't know what version number I was using at the time, but it was whatever Nightly version was available on Google Play at [phone]T13:03:19+01:00.

Comment 53

[Chris Peterson [:cpeterson]]

Unassigning bugs assigned to Arturo

Comment 54

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

This recently recurred. I don't know what version number I was using at the time.

It continues to, occasionally, in V135.

Comment 55

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Continues to reproduce. Browser version is undermentioned:

139.0a1 (Build #2016082983), hg-5d642e3e5989+

GV: 139.0a1-20250403095150
AS: 139.20250402050327

Comment 56

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Attachment: Reproduction in fenix-141.0a1.multi.android-arm64-v8a.apk

Environment

Continues to reproduce in fenix-141.0a1.multi.android-arm64-v8a.apk from 2025-06-06T08:54:16:

141.0a1 (Build #2016095263), null

GV: 141.0a1-20250606085416
AS: 141.20250605050304
OS: Android 14

Diagnosis

At a single URI, where I captured the screenshot, it occurred more consistently when text was selected, for me – the text fragment generation extension that I'd installed appeared to consistently replace Dark Reader's icon when I did so.

Comment 57

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Attachment: Reproduction in fenix-141.0a1.multi.android-arm64-v8a.apk

Attachment is obsolete: true

I shouldn't have uploaded an adb bugreport without setting it as CONFIDENTIAL, since it contains a lot of personal information, so I've removed it.

Attached video

Anyway, I've uploaded a screencast that hopefully demonstrates that when the icons first load, they're in the problematic positions, but very quickly right themselves. This means that somewhere during the loading process, the loading is stopped. It's most evident in the first ≤ 3 frames, due to the low frame rate.