1858439 - Show icon in install dialogs

Status: VERIFIED FIXED

(Firefox for Android :: WebExtensions, enhancement, P3)

Description

[William Durand [:willdurand]]

During install, we have multiple dialogs with a generic add-on icon. We should use the add-on's icon when possible. It looks like, at least for the post-install dialog, we used to have the add-on's icon but that's no longer the case.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1858439 - Show icon in add-on dialogs (#4065)

Comment 2

[BMO Github Automation]

Authored by https://github.com/Amejia481
https://github.com/mozilla-mobile/firefox-android/commit/7172b1e0a9773ccf9bcb92f6c859270438c7eadf
[main] Bug 1858439 - Refactor how addons icons are loaded #4065

Comment 3

[Chris Peterson [:cpeterson]]

Arturo, do you want to uplift this fix to Beta 120 for addons GA in 120? Or can it ride the trains with 121?

Comment 4

[Arturo Mejia [:amejia]]

Yes, we want to uplift it, but we would like to have some baking time on nightly, as we did some major refactor on how we load extension icons. The plan is to have it on nightly until next Monday and if everything goes well uplift it to 120.

Comment 5

[William Durand [:willdurand]]

I don't see why we wouldn't need QA on this bug. It's changing how we load add-on icons as well as adding icons to different install dialogs.

Comment 6

[Adina Petridean QA [:apetridean]]

Attachment: addons.JPEG

Comment 7

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 121.0a1 from 10/31 with Motorola Moto G9 plus (Android 11) and Sony Xperia (Android 6.0.1).

Comment 8

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1858439 - Refactor how addons icons are loaded (backport #4065) (#4331)

Comment 9

[Arturo Mejia [:amejia]]

Comment on attachment 9361627 [details] [review]
[mozilla-mobile/firefox-android] Bug 1858439 - Refactor how addons icons are loaded (backport #4065) (#4331)

Beta/Release Uplift Approval Request

• User impact if declined: Users won't be able to see add-on icons as of the installation installation popups
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): We did some refactor on how we load add-ons icons, which imply some level of risk, but at the same time we are improving how fast icons loads, and addressed multiple old issues. As we had some backing time in nightly without any report, we think this safe to uplift.
• String changes made/needed:
• Is Android affected?: Yes

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9361627 [details] [review]
[mozilla-mobile/firefox-android] Bug 1858439 - Refactor how addons icons are loaded (backport #4065) (#4331)

Approved for Mobile 120.0b6

Comment 11

[BMO Github Automation]

Authored by https://github.com/Amejia481
https://github.com/mozilla-mobile/firefox-android/commit/0cb8b25ca09c6a04bcd13fa793130295f8d8b15a
[releases_v120] Bug 1858439 - Refactor how addons icons are loaded #4065

Comment 12

[Delia Pop (Android QA)]

Verified fixed on Firefox Beta 120.0b6 from 06/11 with Huawei MediaPad M2 (Android 5.1.1) and Motorola G9 plus (Android 11).

Comment 13

[Arturo Mejia [:amejia]]

Thanks Delia!