180684 - Search for Flag + Flag Setter Error

Status: RESOLVED DUPLICATE of bug 275523

(Bugzilla :: Query/Bug List, defect)

Description

[John Keiser (jkeiser)]

On bugzilla.mozilla.org, searching for "in the last 10 days" + "Flag is review"
and "Flag Setter is [e-mail]" yields an error:

SELECT bugs.bug_id, bugs.bug_severity, bugs.priority, bugs.rep_platform,
map_assigned_to.login_name, bugs.bug_status, bugs.resolution, bugs.short_desc
FROM bugs, profiles AS map_assigned_to LEFT JOIN flags flags_0 ON bugs.bug_id =
flags_0.bug_id LEFT JOIN flagtypes flagtypes_0 ON flags_0.type_id =
flagtypes_0.id, flags flags_0, profiles setters_0 LEFT JOIN bug_group_map  ON
bug_group_map.bug_id = bugs.bug_id  AND bug_group_map.group_id NOT IN (5,9,10) 
LEFT JOIN cc ON cc.bug_id = bugs.bug_id AND cc.who = 9757  WHERE
bugs.assigned_to = map_assigned_to.userid AND bugs.bug_id = flags_0.bug_id AND
flags_0.setter_id = setters_0.userid AND (bugs.bug_status IN
('NEW','ASSIGNED','REOPENED','RESOLVED','VERIFIED')) AND ((to_days(now()) -
to_days(bugs.delta_ts)) < '11') AND (CONCAT(flagtypes_0.name, flags_0.status) =
'review') AND (setters_0.login_name = '[e-mail]') AND
((bug_group_map.group_id IS NULL)    OR (bugs.reporter_accessible = 1 AND
bugs.reporter = 9757)     OR (bugs.cclist_accessible = 1 AND cc.who IS NOT NULL)
    OR (bugs.assigned_to = 9757) OR (bugs.qa_contact = 9757) ) GROUP BY
bugs.bug_id ORDER BY bugs.bug_id : Not unique table/alias: 'flags_0' at
globals.pl line 242.

Comment 1

[Bradley Baetz (:bbaetz)]

You need to be searching for "review?", btw, not just review, if you use the
'flag' search thing. Its also really slow, so you're better off using
request.cgi anyway. See bug 179599 for speeding this up.

Anyway, the reason this is happening is because one of the flag joins (for the
flag itsself) is a left join, but the requester search is an inner join, so the
duplicate removal code doens't kikc in.

Why the difference?

Comment 2

[John Keiser (jkeiser)]

Actually, I was trying to search for all bugs that I had reviewed during that
time period--Request Tracker stops tracking when it leaves the ? state. 
Obviously I was doing this wrong too and needed "contains review" or "review+ or
review-".

Comment 3

[timeless]

um. between request queue not showing requests that have been granted, and this
bug, how am i supposed to find approved bugs? 
buglist.cgi?query_format=&short_desc_type=allwordssubstr&short_desc=&product=Browser&product=MailNews&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=allwords&keywords=&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&emailassigned_to1=1&emailtype1=exact&email1=&emailassigned_to2=1&emailreporter2=1&emailqa_contact2=1&emailtype2=exact&email2=&bugidtype=include&bug_id=&votes=&changedin=14+&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&remaction=run&namedcmd=beos-checkins&order=Reuse+same+sort+as+last+time&field0-0-0=requesters.login_name&type0-0-0=equals&value0-0-0=timeless%40bemail.org&field0-1-0=flagtypes.name&type0-1-0=equals&value0-1-0=review%2B&field0-2-0=flagtypes.name&type0-2-0=equals&value0-2-0=superreview%2B

Comment 4

[Bradley Baetz (:bbaetz)]

You can search for approved bugs using 'approved+' (or whatever). You just can't
search for bugs that a particular person approved.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

Here's a patch that fixes the problem.

Comment 6

[Bradley Baetz (:bbaetz)]

Comment on attachment 109612 [details] [diff] [review]
patch v1: fixes problem

	      push(@supptables, "LEFT JOIN flags $flags " .
-				"ON bugs.bug_id = $flags.bug_id");
+				"ON bugs.bug_id = $flags.bug_id")
+		unless grep(/flags flags_$chartid/, @supptables);

That doesn't look right...

This is hacky in any event, but its probably the best we have.

Comment 7

[Max Kanat-Alexander]

This really should be dealt with by Bugzilla 2.22. Can we Target it for that,
and I'll take a look at it if I actually ever get the chance... maybe...?

(I'm guessing the version that was on b.m.o based on the date this bug was
filed, and setting the version in this bug appropriately.)

Comment 8

[Joel Peshkin]

We have to decide if searches within a chart want to be for multiple flags on a
single attachment or if they want to be for multiple aspects of a single flag.

After all, if we search for flag, changedby, justdave and flag contains review+,
we might or might not want a bug that was justdave- and myk+

Comment 9

[Max Kanat-Alexander]

There probably ought to be some way to handle both cases, I'd think.

Comment 10

[Joel Peshkin]

(In reply to comment #9)

Let's start by proposing how we would make that clear (but still consistent) in
the UI.  If someone can propose that, I'll see if I can make the back-end follow
that intent.
 

Comment 11

[Dave Miller [:justdave]]

This appears to have been fixed already on another bug...  duping.

*** This bug has been marked as a duplicate of 275523 ***