1806860 - Status Bar in Message Compose Window cannot be hidden anymore

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Alexander Bergmann]

The status bar in the message compose window cannot be hidden anymore. Selecting and unselecting the status bar via "Tools -> Toolbars -> Status Bar" has no effect. The status bar is always visible.

I bisected the problem and the pushlog in question is:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=371b1b50cb6cab038c0a438f293ebb824621ffd0&tochange=f6177d7407da24aabc5dd82da8a5a2109f289de1

I suspect the problem to be related to this changeset:
https://hg.mozilla.org/comm-central/rev/991627ce316e87772659b4d85f531012cd32979e

Comment 1

[Thomas D. (:thomas8)]

Confirming for TB 102.6.1, Win10. Nothing in error console.

(In reply to Alexander Bergmann from comment #0)

I suspect the problem to be related to this changeset:
https://hg.mozilla.org/comm-central/rev/991627ce316e87772659b4d85f531012cd32979e

Thanks Alex, that sounds right. The changeset is from Bug 1683865 - Changed status bar to HTML.
Might be a good first bug.

Comment 2

[Alessandro Castellani [:aleca]]

This is the culprit!
https://hg.mozilla.org/comm-central/rev/991627ce316e87772659b4d85f531012cd32979e#l9.35

We should update that snippet to .statusbar:not([hidden="true"]) as a quick fix.
We need to explicitly use [hidden="true"] and not just [hidden] because the toggleToolbar() function triggered from the View menu still handles XUL toolbars and uses the setAttribute("hidden", true/false).

We should also use the occasion to add a test to cover this area.
Elizabeth, would you like to take care of this so you can start experimenting with our testing infrastructure? You can tackle this after the holiday shutdown.
You can ask Martin for guidance on how to find the proper test and further knowledge transfer on how to implement a new check in an existing test.

Comment 3

[Elizabeth Mitchell]

Yes, I will take care of this in early January.

Comment 4

[Elizabeth Mitchell]

Attachment: WIP: Bug 1806860 - Hide status bar when user hides it.

Comment 5

[Elizabeth Mitchell]

This work is on hold at the moment due to higher priority work. If anyone wants to take this on, they are welcome to do so.

Comment 6

[Owen Wang [:Newo]]

I'm starting to work on this bug and sent my first patch to Phabricator here. Could I be assigned this bug?

Unfortunately, I am not sure how to edit tests for this but would be glad to work with Mark.

Comment 7

[Owen Wang [:Newo]]

Attachment: Bug 1806860 Fix Hiding Status Bar in Message Compose Window r=aleca

Comment 8

[Alessandro Castellani [:aleca]]

Launched a try-run to make sure we're not affecting anything else: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=ecacbae32ed17fcb0f2a57db982c544279eab5d7

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8b4bbad19903
Fix Hiding Status Bar in Message Compose Window r=aleca

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9334463 [details]
Bug 1806860 Fix Hiding Status Bar in Message Compose Window r=aleca

[Triage Comment]
Approved for beta

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 118.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/0b8f9b6459bd

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9334463 [details]
Bug 1806860 Fix Hiding Status Bar in Message Compose Window r=aleca

[Triage Comment]
Approved for esr115

Comment 13

[Daniel Darnell [:dandarnell]]

Thunderbird 115.3.0:
https://hg.mozilla.org/releases/comm-esr115/rev/b2d0d17bc84b