1807154 - Desktop site option not remembered when Fenix is closed, and re-opened

Status: NEW

(Fenix :: General, defect, P2)

Description

[Christian Sadilek [:csadilek]]

From github: https://github.com/mozilla-mobile/fenix/issues/11552.

Steps to reproduce

1 open a new tab for www.theverge.com (or any website)

2 switch the option to request desktop site and wait for it to fully load

3 open and browse on other tabs enough so when you come back to the verge tab it has to be reloaded and rendered again (I guess it depends on how much ram the device has).

Expected behavior

Site is reloaded in desktop version.

Actual behavior

Site is reloaded in mobile version, with the desktop site option enabled visually and when you try to disable it it reloads the page still in mobile version and remains visually enabled, preventing you from loading the desktop version at all.

Device information

• Android device: Galaxy s9, Android 9
• Fenix version: Nightly 200613 06:01 (Build #2015745971)

UNITO-UNDERSCORE!20200613-104536!UNITO-UNDERSCORE!Firefox Nightly!
UNITO-UNDERSCORE!20200613-105112!UNITO-UNDERSCORE!Firefox Nightly!

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Mason]

This bug has been a frequent dupe for years
(meaning it affects a large number of users)

https://github.com/mozilla-mobile/fenix/issues/11552
https://github.com/mozilla-mobile/fenix/issues/13202
https://github.com/mozilla-mobile/fenix/issues/14737
https://github.com/mozilla-mobile/fenix/issues/15352
https://github.com/mozilla-mobile/fenix/issues/25338

Github sucks at tracking dupes, so the above list is incomplete.

Is there a new team working on Fenix?

Comment 3

[miralobontiu]

Attachment: az_recorder_20230523_121548.mp4

I was able to reproduce this bug with the following STR:

1. Go to https://messenger.com.
2. Go to the three-dot menu, and enable the "Desktop site" toggle to show desktop version.
3. Close Fenix, even from the device's recently used apps.
4. Re-open Fenix - the page from step 1 is in mobile mode, the Desktop toggle is OFF.

Reproducible on Nightly 115.0a1 from 5/23, Beta 114.0b7, and RC 113.2.0, with Samsung Galaxy Note 8 (Android 9).

Comment 4

[Mason]

The subject was changed
from "when page has to be reloaded"
to "when Fenix is closed, and re-opened"
However, the former may have been more general?

Specifically, the problem described in most of the Github issues
was that Firefox (since v93) unloads "inactive" tabs from memory
when the system is low on RAM
(which, on Android, seems to occur "from boot to shutdown")

Comment 5

[Mason]

Attachment: fenix_desktop_mode_issue.mp4

Comment 6

[Jonathan Almeida [:jonalmeida]]

This might be a little simpler than it seems, I think:

1. Persist the desktop mode state with the BrowserStateWriter.
2. Restore the desktop mode state with the BrowserStateReader.
3. In the EngineSession.restoreState, read and toggle state and call toggleDesktopMode without reloading the page. We need do this for Gecko and System EngineSessions.

I think that would solve the problem when the engine is recreated because it was killed or when it's restored from disk.

If we call toggleDesktopMode before this line in the restore, that should apply the session setting before the full restore is done and before the first load has started.Ideally though, we should have GV's session restore take that state value in it's restore API and apply it there.

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1807154: Persist desktop mode option for tabs when Fenix is reopened (#2276)

Comment 9

[Delia Pop]

This issues is still reproducible as described in comment 3 in Beta 117.0b4 with Samsung Galaxy A53 5G (Android 13).