1807233 - Treecol labels not cropped

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: image.png

For example in the Firefox Library window the treecol labels aren't cropped at the end of the treecol. They bleed into the next treecol.

Emilio, is this a modern flexbox issue? Or is this a regression from bug 1799093 or bug 1799193?

Comment 1

[Clara B.]

In Thunderbird beta 109 and Daily the rightmost tree column header can overlap the tree column selector rendering it dysfunctional since the column header absorbs the clicks. Not seen in the older TB beta 108 so something that was introduced during the 109 cycle (hence after 2022-11-14).

Comment 2

[Alice0775 White]

I was able to reproduce the problem with the library column headers in Firefox 109.0b5.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0f84b85f120f45fe6bad63d5e26b5ba4cd89f801&tochange=fd69d6b3aeb8e1e04334a0885f60966883a69c08

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1807233 - Make treecol labels crop again. r=Gijs,dao

This is the lower-risk fix. Ideally we'd move all the places windows etc
to use modern flex layout, but that might be worth doing at some other
time.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbd4db7fae19
Make treecol labels crop again. r=Gijs

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bbd4db7fae19

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9309760 [details]
Bug 1807233 - Make treecol labels crop again. r=Gijs,dao

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Well targeted CSS tweak.
• String changes made/needed: none
• Is Android affected?: No

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9309760 [details]
Bug 1807233 - Make treecol labels crop again. r=Gijs,dao

Approved for 109.0b7

Comment 9

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7aa0da25c427

Comment 10

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly from 2022-12-25, verified that using latest Nightly 110.0a1 and latest Beta build from treeherder (https://treeherder.mozilla.org/jobs?repo=mozilla-beta&revision=b13535d516b6b38dbbce82d10dceeb3b97b01235) across platforms (Windows 10, Ubuntu 22.04 and macOS 13) the column header is not cropped when resizing and does not bleed into the next column.