1807567 - Custom search engine list shows a letter icon instead of search engine's actual favicon

Status: NEW

(Fenix :: Search, defect)

Description

[Chris Peterson [:cpeterson]]

From github: https://github.com/mozilla-mobile/fenix/issues/19265.

Steps to reproduce

Go to Settings>Search>Add search engine>Other and add a search engine that isn't in Firefox by default (for example okeano.com or genius.com)

Expected behavior

It's icon/thumbnail should show up the same way it does for Google, Duckduckgo ect.

Actual behavior

Instead of it's icon it shows the first letter of the name you chose to give it ontop of a coloured backround

Device information

• Samsung Galaxy A30s Android 10
• Firefox for Android version: 88.1.1

┆Issue is synchronized with this Jira Story

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Muhammadhussein Ammari]

I can confirm the issue is reproducible on Firefox Nightly 113.0a1

Comment 5

[jackyzy823]

Some digging:
https://github.com/mozilla-mobile/firefox-android/blob/main/fenix/app/src/main/java/org/mozilla/fenix/settings/search/AddSearchEngineFragment.kt#L184
requireComponents.core.icons.loadIcon(IconRequest(searchString)).await().bitmap,

I'm not sure if it is intentional or not. IconRequest without resources arguments will always fallback to create a generated icon of the first letter of search url.

---

However i have no idea how to construct resources list (there're a lot of icon types) and there's no way to know icon's url (maybe pages' link rel, webmanifest or opensearch.xml , but that's another case)

Comment 6

[schmoken]

I came up with a work around for this. (It does require a rooted phone.)

Would it be proper to post this method here?

Comment 7

[chris122380]

This is still an issue on Firefox
122.1.0 (Build #2016001831), 0d66540568+
GV: 122.0.1-20240205133611
AS: 122.0.1

Comment 9

[andrealuigi.mazzola]

The bug is still present on version 128.0

Comment 10

[[e-mail]]

Somehow still a problem on version 131.0.3

Comment 11

[chris122380]

This is one of many bugs that is a prime example that Mozilla has no care in the world to fix Firefox for mobile. It is still one of the slowest browsers on mobile and it doesn't matter how much you report it to them, they ask you to report it. I have no desire to use Firefox on mobile until they can start fixing some of these bugs and listening to their users.

Comment 13

[chris122380]

Still a bug in Firefox 133.0

Comment 14

[Chris Peterson [:cpeterson]]

Attachment: image.png

Screenshot of the custom search engines using the letter icon (E) instead of Ecosia's actual favicon.

From https://support.mozilla.org/en-US/questions/1357535

Comment 15

[Jonathan Almeida [:jonalmeida]]

A user reported that they are still facing this bug but isn't is a problem on desktop. Bugs like this can be fixed if we also fixed bug 1770989.

For now, bug 1940277 mitigates this temporarily.

EDIT: desktop doesn't have favicons for custom search engines so this doesn't apply. Leaving 1940277 dependency because this might still be relevant depending on how favicon storage will work in the future (and if it will still come through GV).

Comment 16

[Jonathan Almeida [:jonalmeida]]

Attachment: bug reproduction steps.m4v

A video of the bug taken by a user.