Closed Bug 1940277 Opened 2 months ago Closed 1 month ago

Add custom search engine icons urls into Fenix

Categories

(Fenix :: Search, enhancement)

All
Android
enhancement

Tracking

(firefox134 fixed, firefox135 fixed, firefox136 fixed)

RESOLVED FIXED
136 Branch
Tracking Status
firefox134 --- fixed
firefox135 --- fixed
firefox136 --- fixed

People

(Reporter: royang, Assigned: royang)

References

Details

(Whiteboard: [fxdroid][group3])

Attachments

(1 file)

Currently we have a list of icons that allows us to show icons without loading the page.

For the custom search engine list use case, add the top general search engine list from here so icons can be correctly displayed.

Whiteboard: [fxdroid][group3]
Assignee: nobody → royang
Status: NEW → ASSIGNED
Pushed by royang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7607134c1902 Update and add general search engines in top 200 icons list. r=android-reviewers,jonalmeida
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch

Confirmed fixed in latest nightly, I'll nominate for beta uplift.

Comment on attachment 9446128 [details]
Bug 1940277 - Update and add general search engines in top 200 icons list.

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: This updates and allow users to add top search engines and see the correct icons
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This only updates icons.
  • String changes made/needed: None
  • Is Android affected?: Yes
Attachment #9446128 - Flags: approval-mozilla-release?
Attachment #9446128 - Flags: approval-mozilla-beta?

Comment on attachment 9446128 [details]
Bug 1940277 - Update and add general search engines in top 200 icons list.

Approved for 135.0b4.

Attachment #9446128 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9446128 [details]
Bug 1940277 - Update and add general search engines in top 200 icons list.

That looks low-risk, taking for 134.0.2, thanks.

Attachment #9446128 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: