1807892 - Dropdown with enough options to require a scrollbar causes options to be shortened with ellipses

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Emanuel Hoogeveen [:ehoogeveen]]

Attachment: Dropdown testcase

Bisected using mozregression, caused by bug 1805694.

Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=30fc4653fdff8501187251bf8256e50df825acbd&tochange=e61e04de54d1b3b90eadfedd3906fa310e887ad3

Steps to reproduce:

1. From a fresh profile on the latest Nightly,
2. Open the attached testcase and click the dropdowns.

Expected behavior:
The dropdown with the scrollbar should show the options without shortening them.

Actual behavior:
In the dropdown that requires a scrollbar, the options only show "20...", while the dropdown without a scrollbar shows the full years.

Tested on Windows 10 (21H2). Other operating systems might show different results due to different native scrollbar styling.

Emilio, could you have a look?

Comment 1

[Emanuel Hoogeveen [:ehoogeveen]]

Attachment: Screenshot of the problem

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1805694

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1807892 - Keep accounting for scrollbar sizes on menulist popup intrinsic size. r=tnikkel,#layout

See the comment for why we can't just use scrollbar-gutter: stable,
which is what we'd want, ideally.

This is reproducible on Win10 and also Linux as long as:

• Overlay scrollbars are disabled.
• The scrollbar size is bigger than the menulist arrow size.

This used to be done by the chunk of code here:

• https://hg.mozilla.org/integration/autoland/rev/8f61a444ce01d08e22efe35220fd171ca77fb10f#l7.82

Which changed the size of the menu (not just the popup) which then the
popup expanded to. So quite hacky over-all.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1807892 - Some minor improvements to popup sizing code. r=tnikkel,#layout

This doesn't change behavior but should make what's going on slightly
clearer.

Depends on D165669

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Thanks a lot for the report!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/832901f88c03
Keep accounting for scrollbar sizes on menulist popup intrinsic size. r=tnikkel,layout-reviewers
https://hg.mozilla.org/integration/autoland/rev/5c0d75f58aaa
Some minor improvements to popup sizing code. r=tnikkel,layout-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdf5bdc50976
Fix test_popup_recreate.xhtml on some platforms.

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/832901f88c03
https://hg.mozilla.org/mozilla-central/rev/5c0d75f58aaa
https://hg.mozilla.org/mozilla-central/rev/bdf5bdc50976

Comment 9

[Emanuel Hoogeveen [:ehoogeveen]]

I can confirm that it's fixed in the current Nightly, thanks!