1805694 - Simplify menulist popup layout.

Status: RESOLVED FIXED

(Firefox :: Menus, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1805694 - Simplify menulist popup layout. r=Gijs

I decided to split this up from bug 1805414 because it's only
tangentially related to the removal of nsMenuFrame.

We have this sizetopopup attribute and behavior that allows menulists to
be sized to the contents of the popup. The popup also expands to the
menulist rect.

This means that layout is by somewhat cyclic and we need to go out of
our way to support it. However, I think we only care about the first
behavior. We don't have many non-intrinsically-sized menulists, and
if we need we can use HTML <select> instead, which does have that
behavior.

Simplify the setup to make sizetopopup only apply to menulists (we don't
have non-menulist usage anyways), and only work in the "popup depends on
the menulist" direction, not the other way around.

This will allow making the popup a regular out-of-flow element. The
change to test_menulist_paging is not needed (I restored the behavior of
eagerly layout menulists, to fix the <select> popup, but I'd like to fix
that eventually, so I'd rather leave them in, they're harmless).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48f2dad16e54
Simplify menulist popup layout. r=tnikkel

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_selectpopup.js

Backout link

Push with failures

Failure log

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1805694 - Allow browser_selectpopup_large to partially fail on win7. r=Gijs

I can't repro this at all on win10 with either native or non-native
menus, nor hacking my way so that all win7 styles apply, nor on win7 by
hand on a VM... So that kinda sucks :(

Let's take this very minor regression in this subtest? I don't think
it's particularly worrisome (the select looks good in the mochitest
failure screenshot and works ok in local testing...).

Depends on D164693

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f61a444ce01
Simplify menulist popup layout. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/e61e04de54d1
Allow browser_selectpopup_large to partially fail on win7. r=Gijs

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8f61a444ce01
https://hg.mozilla.org/mozilla-central/rev/e61e04de54d1