Closed Bug 1807963 Opened 2 years ago Closed 2 years ago

Simplify caption-side code.

Categories

(Core :: Layout: Tables, task)

Product:
Core
Component:
Layout: Tables
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
110 Branch
Tracking Flags:
Tracking Status
firefox110 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1807963 - Remove non-standard values of caption-side for good. r=TYLin
48 bytes, text/x-phabricator-request
Details | Review
No description provided.

They have been disabled since bug 1688695. There's a variety of
table-caption bugs that would be easier to fix if we didn't have to
account for side-captions.

Attachment #9310152 - Attachment description: Bug 1807963 - Remove non-standard values of caption-side for good. r=TYLin,#layout-reviewers → WIP: Bug 1807963 - Remove non-standard values of caption-side for good. r=TYLin,#layout-reviewers
Attachment #9310152 - Attachment description: WIP: Bug 1807963 - Remove non-standard values of caption-side for good. r=TYLin,#layout-reviewers → Bug 1807963 - Remove non-standard values of caption-side for good. r=TYLin,#layout-reviewers
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e018ba23c07d Remove non-standard values of caption-side for good. r=TYLin,layout-reviewers
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37801 for changes under testing/web-platform/tests

Backed out for causing wpt failures in caption.html.

Flags: needinfo?(emilio)
Upstream PR was closed without merging
Attachment #9310152 - Attachment description: Bug 1807963 - Remove non-standard values of caption-side for good. r=TYLin,#layout-reviewers → Bug 1807963 - Remove non-standard values of caption-side for good. r=TYLin
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c34c31220275 Remove non-standard values of caption-side for good. r=TYLin,layout-reviewers
Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c4cec23bed47 Backed out changeset c34c31220275 for causing reftest unexpected passes on 446100-1c.html.
Upstream PR was closed without merging

Backed out for causing reftest failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c4cec23bed47e330173e9d1d32843abd41b892af

Push with failures

Failure log

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66722eec1643 Remove non-standard values of caption-side for good. r=TYLin,layout-reviewers
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/9e00990703b1 More unexpected passes in layout/reftests/bugs.

Backed out for causing reftests failures in layout/reftests/bugs.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: REFTEST TEST-UNEXPECTED-PASS | layout/reftests/bugs/446100-1b.html == about:blank | image comparison, max difference: 177, number of differing pixels: 127
Flags: needinfo?(emilio)

https://hg.mozilla.org/mozilla-central/rev/66722eec1643

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox110: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
Flags: needinfo?(emilio)
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/f505094e277d More unexpected passes in layout/reftests/bugs.
Upstream PR merged by moz-wptsync-bot
See Also: → 1850752
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: