Closed
Bug 1870558
Opened 6 months ago
Closed 6 months ago
Clean up in table wrapper
Categories
(Core :: Layout: Tables, task)
Core
Layout: Tables
Tracking
()
RESOLVED
FIXED
123 Branch
| Tracking | Status | |
|---|---|---|
| firefox123 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(4 files)
After we removed side caption support in bug 1807963, I notice some cleanup opportunities in nsTableWrapperFrame.
|
Assignee | |
Comment 1•6 months ago
|
||
We've removed side captions in bug 1807963, so we should remove/update obsolete
comments.
This patch doesn't change behavior.
|
||
Updated•6 months ago
|
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 months ago
|
||
Depends on D196697
|
|
Assignee | |
Comment 3•6 months ago
|
||
Depends on D196698
|
|
Assignee | |
Comment 4•6 months ago
|
||
This doesn't change the behavior.
Depends on D196699
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/9c274490e6fc Part 1 - Remove unused containSize variable in nsTableWrapperFrame::Reflow(). r=layout-reviewers,emilio https://hg.mozilla.org/integration/autoland/rev/d8dac70b5aca Part 2 - Remove unused captionWM in nsTableWrapperFrame::Reflow(). r=layout-reviewers,emilio https://hg.mozilla.org/integration/autoland/rev/0ecd3e6b8ba0 Part 3 - Remove unused caption side argument for nsTableWrapperFrame::ComputeFinalBSize(). r=layout-reviewers,emilio https://hg.mozilla.org/integration/autoland/rev/20db9fbc5718 Part 4 - Simplify the caption reflow setup in nsTableWrapperFrame::Reflow(). r=layout-reviewers,emilio
|
||
Comment 6•6 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9c274490e6fc
https://hg.mozilla.org/mozilla-central/rev/d8dac70b5aca
https://hg.mozilla.org/mozilla-central/rev/0ecd3e6b8ba0
https://hg.mozilla.org/mozilla-central/rev/20db9fbc5718
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox123:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•