1870558 - Clean up in table wrapper

Status: RESOLVED FIXED

(Core :: Layout: Tables, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

After we removed side caption support in bug 1807963, I notice some cleanup opportunities in nsTableWrapperFrame.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1870558 Part 1 - Remove unused containSize variable in nsTableWrapperFrame::Reflow(). r?#layout

We've removed side captions in bug 1807963, so we should remove/update obsolete
comments.

This patch doesn't change behavior.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1870558 Part 2 - Remove unused captionWM in nsTableWrapperFrame::Reflow(). r?#layout

Depends on D196697

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1870558 Part 3 - Remove unused caption side argument for nsTableWrapperFrame::ComputeFinalBSize(). r?#layout

Depends on D196698

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1870558 Part 4 - Simplify the caption reflow setup in nsTableWrapperFrame::Reflow(). r?#layout

This doesn't change the behavior.

Depends on D196699

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c274490e6fc
Part 1 - Remove unused containSize variable in nsTableWrapperFrame::Reflow(). r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/d8dac70b5aca
Part 2 - Remove unused captionWM in nsTableWrapperFrame::Reflow(). r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/0ecd3e6b8ba0
Part 3 - Remove unused caption side argument for nsTableWrapperFrame::ComputeFinalBSize(). r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/20db9fbc5718
Part 4 - Simplify the caption reflow setup in nsTableWrapperFrame::Reflow(). r=layout-reviewers,emilio

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9c274490e6fc
https://hg.mozilla.org/mozilla-central/rev/d8dac70b5aca
https://hg.mozilla.org/mozilla-central/rev/0ecd3e6b8ba0
https://hg.mozilla.org/mozilla-central/rev/20db9fbc5718