1807967 - Hit MOZ_CRASH(called `Result::unwrap()` on an `Err` value: InvalidId) at /third_party/rust/wgpu-core/src/device/queue.rs:598

Status: VERIFIED FIXED

(Core :: Graphics: WebGPU, defect, P1)

Description

[Jason Kratzer [:jkratzer]]

Testcase found while fuzzing mozilla-central rev c5ddc463e9f8 (built with: --enable-debug --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build c5ddc463e9f8 --debug --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html

Hit MOZ_CRASH(called `Result::unwrap()` on an `Err` value: InvalidId) at /third_party/rust/wgpu-core/src/device/queue.rs:598

    ==182055==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7f398383c725 bp 0x7f395c33b7f0 sp 0x7f395c33b7e0 T182125)
    ==182055==The signal is caused by a WRITE memory access.
    ==182055==Hint: address points to the zero page.
        #0 0x7f398383c725 in MOZ_Crash /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:261:3
        #1 0x7f398383c725 in RustMozCrash /mozglue/static/rust/wrappers.cpp:18:3
        #2 0x7f398383c6a2 in mozglue_static::panic_hook::h1ef58ebb5b1fb726 /mozglue/static/rust/lib.rs:91:9
        #3 0x7f398383c16b in core::ops::function::Fn::call::h944214cc829a0480 /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/core/src/ops/function.rs:78:5
        #4 0x7f39848e6fa8 in _$LT$alloc..boxed..Box$LT$F$C$A$GT$$u20$as$u20$core..ops..function..Fn$LT$Args$GT$$GT$::call::h44df53ea2a13204b /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/alloc/src/boxed.rs:2001:9
        #5 0x7f39848e6fa8 in std::panicking::rust_panic_with_hook::hfd45b6b6c12d9fa5 /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/std/src/panicking.rs:692:13
        #6 0x7f39848e6d26 in std::panicking::begin_panic_handler::_$u7b$$u7b$closure$u7d$$u7d$::hf591e8609a75bd4b /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/std/src/panicking.rs:579:13
        #7 0x7f39848e405b in std::sys_common::backtrace::__rust_end_short_backtrace::h81899558795e4ff7 /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/std/src/sys_common/backtrace.rs:137:18
        #8 0x7f39848e6a41 in rust_begin_unwind /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/std/src/panicking.rs:575:5
        #9 0x7f398493d702 in core::panicking::panic_fmt::h4235fa9b4675b332 /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/core/src/panicking.rs:65:14
        #10 0x7f398493dc72 in core::result::unwrap_failed::ha17dbf463031a5e1 /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/core/src/result.rs:1791:5
        #11 0x7f3982bf7f11 in wgpu_server_queue_write_action /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/core/src/result.rs
        #12 0x7f397d5cc153 in mozilla::webgpu::WebGPUParent::RecvQueueWriteAction(unsigned long, unsigned long, mozilla::ipc::ByteBuf const&, mozilla::ipc::UnsafeSharedMemoryHandle&&) /dom/webgpu/ipc/WebGPUParent.cpp:627:3
        #13 0x7f397d5e505c in mozilla::webgpu::PWebGPUParent::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PWebGPUParent.cpp:1482:80
        #14 0x7f397b5ae640 in mozilla::gfx::PCanvasManagerParent::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PCanvasManagerParent.cpp:214:32
        #15 0x7f397abc954a in mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) /ipc/glue/MessageChannel.cpp:1800:25
        #16 0x7f397abc61c7 in mozilla::ipc::MessageChannel::DispatchMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::UniquePtr<IPC::Message, mozilla::DefaultDelete<IPC::Message>>) /ipc/glue/MessageChannel.cpp:1725:9
        #17 0x7f397abc6cf5 in mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::ipc::MessageChannel::MessageTask&) /ipc/glue/MessageChannel.cpp:1525:3
        #18 0x7f397abc802f in mozilla::ipc::MessageChannel::MessageTask::Run() /ipc/glue/MessageChannel.cpp:1623:14
        #19 0x7f3979fdaa18 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1191:16
        #20 0x7f3979fe0e9d in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:476:10
        #21 0x7f397abd06c3 in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:330:5
        #22 0x7f397aaf2f58 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:381:10
        #23 0x7f397aaf2e61 in RunHandler /ipc/chromium/src/base/message_loop.cc:374:3
        #24 0x7f397aaf2e61 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:356:3
        #25 0x7f3979fd5f17 in nsThread::ThreadFunc(void*) /xpcom/threads/nsThread.cpp:383:10
        #26 0x7f398cdaac86 in _pt_root /nsprpub/pr/src/pthreads/ptthread.c:201:5
        #27 0x7f398d64bb42 in start_thread nptl/pthread_create.c:442:8
        #28 0x7f398d6dd9ff  misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
    
    UndefinedBehaviorSanitizer can not provide additional info.
    SUMMARY: UndefinedBehaviorSanitizer: SEGV /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:261:3 in MOZ_Crash
    ==182055==ABORTING

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Testcase

Comment 2

[Bugmon [:jkratzer for issues]]

Verified bug as reproducible on mozilla-central 20221229092636-c5ddc463e9f8.
The bug appears to have been introduced in the following build range:

Start: 4f78238d4673be434f4eeff99eb515f31baf6630 (20221217164420)
End: 4d46db3ff28b5b4f80c3587e77f1e162e552b5e0 (20221217231408)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4f78238d4673be434f4eeff99eb515f31baf6630&tochange=4d46db3ff28b5b4f80c3587e77f1e162e552b5e0

Comment 3

[Mayank Bansal]

Got a crash from the testcase: https://crash-stats.mozilla.org/report/index/10fcf008-b2fd-430f-a089-028770230102

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

This bug has been marked as a regression. Setting status flag for Nightly to affected.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

:jimb, since you are the author of the regressor, bug 1806166, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 6

[Jim Blandy :jimb]

I can reproduce this locally.

Comment 7

[Jim Blandy :jimb]

It does seem likely that the wgpu update in Bug 1806166 could be the regressor.

S3 because WebGPU is disabled. P1 because it's a fuzzblocker.

Comment 8

[Jim Blandy :jimb]

Should be fixed by wgpu#3378.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

This bug prevents fuzzing from making progress; however, it has low severity. It is important for fuzz blocker bugs to be addressed in a timely manner (see here why?).
:jimb, could you increase the severity?

For more information, please visit auto_nag documentation.

Comment 10

[Jim Blandy :jimb]

Severity left unchanged:

1. WebGPU is disabled in nightly.
2. A fix is coming in with the next wgpu update.

Comment 11

[Jim Blandy :jimb]

This should be fixed by bug 1810495.

Comment 12

[Tyson Smith [:tsmith]]

(In reply to Jim Blandy :jimb from comment #11)

This should be fixed by bug 1810495.

Thanks, tested with m-c 20230120-f2fbf518572b.

Comment 13

[Bugmon [:jkratzer for issues]]

Verified bug as fixed on rev mozilla-central 20230120212103-f2fbf518572b.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.