Closed Bug 1806166 Opened 2 years ago Closed 2 years ago

Update wgpu to f14bee67 (2022-12-16)

Categories

(Core :: Graphics: WebGPU, task, P1)

task

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: jimb, Assigned: jimb)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Incorporate upstream fixes and improvements into Firefox.

This brings in various bugfixes and improvements from upstream,
including the fix for bug 1791809 and a workaround for bug 1804530.

In this update, wgpu_core leaves the selection of backends to its
users, rather than trying to guess which backends to use itself, based
on the target architecture and operating system. For Firefox, this
means that gfx/wgpu_bindings/Cargo.toml is now responsible for
selecting back ends.

Firefox's WebGPU implementation should never use wgpu's GLES
backend. Firefox can now explain this to wgpu-core, causing it to
drop its dependency on glow, bitflags_serde_shim and slotmap.
These are no longer vendored, and their exemptions in
supply-chain/config.toml can be dropped.

The new wgpu-core updates to version 0.37.1+1.3.235 of the ash
crate, and this patch moves ash's supply-chain exemption forward to
the new version. We expect to finish vetting that next week, but
because this wgpu-core update is urgently needed, we want to extend
the exemption for the time being.

The dependency on slotmap had been patched to an empty file in
build/rust/dummy-web, which can now be removed.

The new wgpu-core no longer uses cfg_aliases, so Firefox no longer
needs to vendor that.

Assignee: nobody → jimb
Attachment #9308756 - Attachment description: WIP: Bug 1806166: Update wgpu to f14bee67 (2022-12-16) → Bug 1806166: Update wgpu to f14bee67 (2022-12-16) r?nical
Status: NEW → ASSIGNED
Pushed by jblandy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c000fcb9853 Update wgpu to f14bee67 (2022-12-16) r=nical,supply-chain-reviewers
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
Regressions: 1806780

(In reply to Pulsebot from comment #2)

Pushed by jblandy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c000fcb9853
Update wgpu to f14bee67 (2022-12-16) r=nical,supply-chain-reviewers

== Change summary for alert #36508 (as of Wed, 21 Dec 2022 10:38:41 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
11% perf_reftest_singletons bloom-basic-2.html macosx1015-64-shippable-qr e10s fission stylo webrender 56.41 -> 50.38
10% perf_reftest_singletons bloom-basic-2.html macosx1015-64-shippable-qr e10s fission stylo webrender 56.85 -> 51.38
10% perf_reftest_singletons bloom-basic.html macosx1015-64-shippable-qr e10s fission stylo webrender 57.03 -> 51.54

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36508

I would not expect this change to have had any effect on perf_reftest_singletons's performance.

Regressions: 1807967
Depends on: 1807935
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: