1808009 - Clean up writable file streams in every web platform test

Status: RESOLVED FIXED

(Core :: DOM: File, task, P3)

Description

[Jari Jalkanen]

OPFS web platform tests FileSystemBaseHandle-remove.js, FileSystemBaseHandle-remove.js and FileSystemBaseHandle-getUniqueId.js contain calls

const writable = await handle.createWritable();

which may cause incorrect outcomes in other tests because the writable does not always get cleaned up. As is already done in the other tests, we should replace them with

const writable = await cleanup_writable(t, await handle.createWritable());

Comment 1

[Jari Jalkanen]

Attachment: Bug 1808009 - Clean up writable file streams after every test. r=#dom-storage

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e69320f3e5c
Clean up writable file streams after every test. r=dom-storage-reviewers,jesup

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1798513, Bug 1808009) for causing failures in FileSystemDirectoryHandle-removeEntry.https.any.worker.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=428ea11e738d3809a423858d60b627cb2d0cf706&selectedTaskRun=aNBvsnKMREuvVKVzC5zxpw.0

Log: https://treeherder.mozilla.org/logviewer?job_id=401967351&repo=autoland&lineNumber=2217

Backout: https://hg.mozilla.org/integration/autoland/rev/044ca2c92694976dd00589c0b164de96206d4940

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7c9d114d774
Clean up writable file streams after every test. r=dom-storage-reviewers,jesup

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d7c9d114d774

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37936 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot