1791409 - Use cleanup_writable() for all createWritable() calls in WPT fs tests

Status: RESOLVED FIXED

(Core :: DOM: File, defect, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

cleanup_writable() ensures that on failure (or exit) the writable will be close()ed, which drops the read lock on the file.

Note that if we're checking for createWritable() to throw, we have to be careful to not await on it.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1791409: Use cleanup_writable for all web-platform tests that call createWritable() r=#dom-storage-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9b56bde89d2
Use cleanup_writable for all web-platform tests that call createWritable() r=dom-storage-reviewers,jari

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a9b56bde89d2

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36620 for changes under testing/web-platform/tests