1808146 - Copying images from Pixiv and pasting them in certain programs is broken

Status: VERIFIED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[vanBobbington12]

Attachment: NVIDIA_Share_2023-01-01_20-29-14.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:108.0) Gecko/20100101 Firefox/108.0

Steps to reproduce:

I went to https://www.pixiv.net and looked at fan art. I then wanted to share fan art in a Discord chat.

To do this, I pressed right click on the image and then "Copy Image". After that I pressed Ctrl+V in the discord chat.

Copying the image from Edge and pasting it works without a problem.
I tried to copy and paste from Firefox and Edge in different orders using this image: https://www.pixiv.net/en/artworks/104051568

1. Copy image in Firefox -> Copy image in Edge -> Paste the Firefox image-> Firefox image works
2. Copy image in Edge -> Copy image in Firefox -> Paste the Firefox image-> Firefox image does not work
3. Copy image in edge -> Copy image in Firefox -> Paste the Edge image-> Paste the Firefox image -> Firefox image works

As a last test, I tried to paste the image copied from Firefox in different places: pasting the image into Paint3D also gives me an error and does not work. Pasting the image in the normal Paint works without a problem.

Actual results:

The copied image is in my Clipboard and seems to be copied properly. However after pasting the image in discord, it does not properly paste the image and only shows the file name but the image preview is empty. Continuing to post the copied image only posts a broken file around 150bytes big and not the full image.

Expected results:

The image should be properly pasted, the preview should work and the full image should be shown after posting it.

Comment 1

[Simona Badau, Desktop QA, PTO 14-27aug]

Tried to reproduce this issue on the latest Nightly 110.0a1 on macOS 11.7, but I did not have any trouble in copying from pixiv.com and pasting in different chats, tried on skype, slack and Facebook - unfortunately I do not have a discord account.

I'm setting this to Core > DOM: Copy & Paste and Drag & Drop, so that our developers could take a look at it - if this is not the right component, please assign a more appropriate one.
Thanks!

Comment 2

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

I was trying to reproduce this on Fx 108 on Win11.

On Fx 108, pasting the image copied from https://www.pixiv.net/en/artworks/104051568 to discord chat didn't work for me. I randomly chose discord channels and used "crtl-v" to paste the image in the chat. Nothing. I didn't even see a preview name. However, I got a warning message for the pasting action in console that made me believe it's an expected behavior on this website. I got the same behavior on Chrome as well as the same warning message. One more note that, pasting the image to certain other webapp, e.g. gdoc, worked as expected.

Dear reporter, did you see the same result as me on Chrome browser? Thank you.

However, I got something worse if I tried this with Nightly 110. Writing this pixiv image to clipboard seems to be broken for me, but I have to check if I enabled custom preferences on my nightly.

Comment 3

[vanBobbington12]

Oh god I am sorry for the late response.

On Chrome I never had this issue. I switched at the end of 2022 to Firefox and used Chrome before that for several years without encountering that issue once. The same can be said for using Edge.

Though during the past month I found out a little bit more information.

For pixiv links with containing a single artwork, it is random if it works or not with an I'd say success chance of 60%.

But for pixiv links that have multiple images in an album, I never once got it to work in firefox.
https://www.pixiv.net/en/artworks/105233040 Here is a submission with 2 images for further testing.

Comment 4

[Tom S. (please needinfo tschuster)]

I think this is caused by a combination of pixiv incredibly strict image hotlinking restriction and the Windows-only AppendImagePromise function. On Windows we will basically try to lazily download the image when pasting it, which will fail because pixiv disallows the download.

I would personally suggest we think about just removing this special behavior on Windows.

Comment 5

[Zakjal]

Been having this issue for several months now, it started out of nowhere at some point.

It's specifically some kind of iteration between discord and firefox. I can copy an image from pixiv using another browser and then paste it on discord without any issue.

Comment 7

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1808146 - When creating a file promise for images, remember the referrer. r?nika

Comment 8

[Tom S. (please needinfo tschuster)]

Fwiw I actually can't reproduce this issue with Discord anymore. However copying this image and trying to paste it onto the Desktop still reliably fails for me.

Comment 9

[Zakjal]

I can still reproduce it just fine. Not working for any images from pixiv being copied and pasted into discord.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1571749d59c
When creating a file promise for images, remember the referrer. r=nika

Comment 11

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a1571749d59c

Comment 12

[Tom S. (please needinfo tschuster)]

Hi! This change should now be in Nightly. Could you check if copying works for you now? (This might also depend on whether you are logged-in?)

Comment 13

[Kyle]

Just tested pixiv using the discord client (my incident that got moved to here)
Issue still persists.
Copied by right click on pixiv image. Ctrl V in discord. Image is still missing but it still pastes some file "data".
Using Nightly 113.0a1 (2023-03-22)

Comment 14

[Tom S. (please needinfo tschuster)]

2023-03-22 is not the right version, you need 2023-03-23.

Comment 15

[Kyle]

Thanks for pointing that out. Updated to 2023-03-23 within firefox nightly.
Tested in pixiv, same method, same image. Now working
Tested on two other sites I was having issues with, danbooru and mangakalot. Both working now as well.

Crossing my fingers but I think you nailed it.

Comment 16

[Tom S. (please needinfo tschuster)]

Amazing, thank you for testing!

Comment 17

[Zakjal]

Using the nightly build worked for me as well. Hope it gets pushed to Firefox soon.(In reply to Tom S [:evilpie] from comment #12)

Hi! This change should now be in Nightly. Could you check if copying works for you now? (This might also depend on whether you are logged-in?)

Comment 18

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:evilpie, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Comment 19

[Ina Popescu, Desktop QA]

I've managed to reproduce this issue by following the STR from Bug 1823134. The image was not pasted properly in the Discord desktop app when copied from Nightly 113.0a1 (2023-03-21) and Firefox 112.0b1 on Windows 10 x64.
The image is properly pasted in the chat opened in the Discord desktop app when copied from Nightly 114.0a1 (2023-04-27) and Firefox 113.0b8.