1808304 - Consider having NthType include OnlyChild and OnlyOfType

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Zach Hoffman [:zrhoffman]]

As :emilio notes, we could remove remove Component::FirstChild, Component::FirstOfType, Component::LastChild, Component::LastOfType, Component::OnlyChild, and Component::OnlyOfType if

• NthType includes OnlyChild and OnlyOfType, and if
• NthSelectorData has a boolean is_function field.

Comment 1

[Zach Hoffman [:zrhoffman]]

Attachment: Bug 1808304 - Represent FirstChild, FirstOfType, LastChild, LastOfType, OnlyChild, and OnlyOfType as functionless Nth variants r?emilio

Like bug 1808226, this doesn't change any behavior, it just simplifies matching.

I also added a WPT JavaScript test for :only-of-type, since dedicated WPT
JavScript tests already exist for the other pseudo-classes this patch
touches.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1808304 - Minor clean-ups and fixes on top of the previous patch. r=zrhoffman

This makes the matching / parsing more self-contained, and I believe
it's generally easier to follow. Also addresses review comments from the
previous patch.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/216344853e42
Represent FirstChild, FirstOfType, LastChild, LastOfType, OnlyChild, and OnlyOfType as functionless Nth variants r=emilio
https://hg.mozilla.org/integration/autoland/rev/93fb62b97919
Minor clean-ups and fixes on top of the previous patch. r=zrhoffman

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37740 for changes under testing/web-platform/tests

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/216344853e42
https://hg.mozilla.org/mozilla-central/rev/93fb62b97919

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot