Closed Bug 1808369 Opened 2 years ago Closed 2 years ago

Port bug 1808115: Remove the separate EmbedPrompter wrapper, use Prompter directly instead

Categories

(Thunderbird :: Upstream Synchronization, task)

Tracking

(thunderbird_esr102 unaffected)

RESOLVED FIXED
110 Branch
Tracking Status
thunderbird_esr102 --- unaffected

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(2 files)

The going-away contract ID @mozilla.org/embedcomp/prompt-service;1 is used in mail/test/browser/shared-modules/PromptHelpers.jsm. Looks like a simple replacement.

Assignee: nobody → rob
Status: NEW → ASSIGNED
Duplicate of this bug: 1808368

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/dd20401fe91f
Port Bug 1808115: Use Prompter service instead of EmbedPrompter. r=mkmelin
https://hg.mozilla.org/comm-central/rev/d705ce795f26
Port Bug 1808115: Convert use of SharedPromptUtils.jsm to PromptUtils.sys.mjs. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch

(In reply to Pulsebot from comment #4)

https://hg.mozilla.org/comm-central/rev/d705ce795f26
Port Bug 1808115: Convert use of SharedPromptUtils.jsm to PromptUtils.sys.mjs. r=mkmelin

This should have been port of bug 1808173 (which didn't land yet, so we're a bit busted atm.) Will back this part out if bug 1808172 doesn't land by next merge.

Attachment #9310559 - Attachment description: Bug 1808369 - Port Bug 1808115: Convert use of SharedPromptUtils.jsm to PromptUtils.sys.mjs. r=#thunderbird-reviewers → Bug 1808369 - Port Bug 1808173: Convert use of SharedPromptUtils.jsm to PromptUtils.sys.mjs. r=#thunderbird-reviewers

This was backed out on comment 6.
Reopening just for clarity and tracking.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

I landed the same changes as D165892 in bug 1808173.

Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: