Open Bug 1808407 Opened 1 year ago Updated 5 months ago

[Session restore, Data loss] Outdated session loaded, sessionstore overwritten, tabs lost

Categories

(Firefox :: Session Restore, defect, P2)

Firefox 102
defect

Tracking

()

UNCONFIRMED

People

(Reporter: cyp561, Unassigned)

References

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

Reboot computer after crash.

Actual results:

Firefox started automatically after rebooting, but showing old tabs (showing previously-closed tabs/windows and missing recently-opened tabs), presumably from the 20th of december.

The files sessionstore-backups/recovery.jsonlz4 and sessionstore-backups/recovery.baklz4 have been automatically overwritten, so it's not possible to try recovering the tabs.

The file sessionstore-backups/upgrade.jsonlz4-20221220102302 is exactly identical to sessionstore-backups/previous.jsonlz4, and presumably the file that was opened.

This has happened at least twice so far. At least the last time was after a reboot after the computer crashed.

Expected results:

Either the current tabs should have opened, or there should have been a warning that the tabs couldn't be opened. The sessionstore-backups/recovery.jsonlz4 and sessionstore-backups/recovery.baklz4 files certainly shouldn't get silently overwritten with outdated data.

The Bugbug bot thinks this bug should belong to the 'Firefox::Session Restore' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Session Restore

I tried to reproduce this issue a few times by hitting about:crashparent in the URL bar in order to crash Firefox a few times, load a different session, crash it again and then quickly restart the PC but I cant seem to reproduce this issue on our end, I tried this on Ubuntu 18.04 as well as on Windows 10.

On What OS did you experience this issue ? was it Ubuntu ?

Did you have any specific websites loaded in Firefox when this issue occured both times ?

Flags: needinfo?(cyp561)

OS is Gentoo. At least one time, it happened after the computer crashed (not just Firefox).

After updating Firefox, I probably have the old version of Firefox still running for a few weeks (might not always notice that Firefox was updated or restart it).

Don't think there's any specific related websites.

Flags: needinfo?(cyp561)

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dao+bmo)

For me, severity would be S1. Don't know whether or not it affects 25% of users though.

Just happened again. Computer just crashed (not related to Firefox), and now all recent tabs are gone (probably anything after 19th of march), and the backup recovery files were of course overwritten as soon as Firefox autostarted, before I get a chance to manually make a backup of them.

$ ls -lt sessionstore-backups/
total 31668
-rw-r--r-- 1 cyp users 4476338 Apr 19 12:48 recovery.jsonlz4
-rw-r--r-- 1 cyp users 4476346 Apr 19 12:48 recovery.baklz4
-rw-r--r-- 1 cyp users 4477902 Mar 19 09:51 upgrade.jsonlz4-20230318224741
-rw-r--r-- 1 cyp users 4477902 Mar 19 09:50 previous.jsonlz4
-rw-r--r-- 1 cyp users 4339812 Feb 27 18:16 upgrade.jsonlz4-20230227161541
-rw-r--r-- 1 cyp users 4296334 Feb 16 10:54 upgrade.jsonlz4-20230215204939
-rw------- 1 cyp users 1960063 Jan 13  2022 recovery.baklz4-2022-01-13
-rw------- 1 cyp users 1960073 Jan 13  2022 recovery.jsonlz4-2022-01-13
-rw------- 1 cyp users  126318 Oct  3  2017 recovery.js
-rw------- 1 cyp users  126318 Oct  3  2017 recovery.bak
-rw------- 1 cyp users  156326 Oct  3  2017 upgrade.js-20170826214816
-rw------- 1 cyp users  156326 Oct  3  2017 previous.js
-rw------- 1 cyp users 1363414 Aug  2  2017 upgrade.js-20170713125424
-rw------- 1 cyp users   12186 Apr 26  2017 upgrade.js-20170326041644

I've been trying to restart Firefox soon after upgrading in case that would help, but I'm not sure whether or not I restarted Firefox the last time it upgraded. One time after upgrading, when opening (or reloading?) a tab, Firefox itself actually asked me to restart itself, mentioning that it had been upgraded in the background.

Adding the Qa not actionable tag for now. Maybe one of our devs can reproduce this issue on their side, Unfortunately I dont have a gentoo OS to try this on.

QA Whiteboard: [qa-not-actionable]

I believe Firefox should be detecting the OS crash and incomplete shutdown and offering you the session restore screen with whatever the latest session backup is we have on disk. If that's not happening, we should figure out why and try to improve users' ability to recover from this situation with the best data we have on disk.

Severity: -- → S3
Flags: needinfo?(dao+bmo)
Priority: -- → P2
Duplicate of this bug: 1809579
You need to log in before you can comment on or make changes to this bug.