180841 - Some GTK2 embedding specific code not #ifdef'ed and crashing GTK1 embedding

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Philip Langdale]

Part of the merged gtk2 embedding code is being used in gtk1 embedding which is
inappropriate and causing crashes in galeon (when closing the right most tab).

This can easily be fixed by #ifdef guarding the single line of code.
I will attach a patch accordingly.

Comment 1

[Philip Langdale]

Attachment: Patch to add #ifdef guard

Comment 2

[Christopher Blizzard (:blizzard)]

Can you tell me why this is causing crashes?  It's not causing crashes here and
I don't see the harm in that code.

Comment 3

[Tommi Komulainen]

I don't know why it would be crashing, I only noticed that was virtually the
only addition in the gtk1 code by the gtk2 port.  Maybe it's simply triggering
some obscure (un)realization bug somewhere.  It is rather obscure to start with
if it crashes only when closing the rightmost tab.

Comment 4

[Chris Nalls]

Changing keyword from topembed (which is used internally for Netscape products)
to embed. Blizzard - if you feel strongly about the topembed keyword, renominate
and we will talk about it with you.

Comment 5

[Philip Langdale]

I blew away my source tree last week and checked out a fresh one and forgot to
apply this fix and it left me very frustrated until I remembered what I had to
do. This is still a very real problem.

Comment 6

[Philip Langdale]

Well, we have fixed this one by explicitly setting the flag that gtkmozembed
tries to unset. This is a work-around, not a fix, IMHO. If the widget is trying
to clear a flag on itself, it should be setting it on itself and not hoping that
the embedding app will...

Comment 7

[Christopher Blizzard (:blizzard)]

Ahh, this fell off my radar because it wasn't linked to the tracking bug.

Comment 8

[Christopher Blizzard (:blizzard)]

Checked in.