Closed Bug 1808459 Opened 2 years ago Closed 1 year ago

Unified Extensions when empty ignores `extensions.getAddons.showPane`

Categories

(WebExtensions :: General, defect, P2)

Firefox 110
defect

Tracking

(firefox-esr102 unaffected, firefox110 wontfix, firefox111 wontfix, firefox112 fixed)

RESOLVED FIXED
112 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox110 --- wontfix
firefox111 --- wontfix
firefox112 --- fixed

People

(Reporter: thorin, Assigned: mjurgens)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

STR

  • don't have any extensions in the Unified Extensions panel
  • check extensions.getAddons.showPane is deleted (hidden pref)
  • click the Unified Extensions button
  • it takes you to about:addons > Recommendations = good
  • set extensions.getAddons.showPane = false
  • click the Unified Extensions button
  • it takes you to about:addons > Recommendations = not so good (IMO)

Expected

  • it should take you to about:addons > Extensions because enterprises (or users) have disabled recommendations (and/or users have extensions or they are disabled, i.e they are just not in the Unified Extensions panel - hence why to instead land on Extensions - unless you wanted to enumerate extensions and if none land on themes? seems like overkill)

In case the user does not have any active extensions listed, if extensions.getAddons.showPane is set to true (default), clicking on the unified extensions button will lead to the recommendations section in about:addons. If it is set to false, clicking the button will now lead to the extension list instead of the, disabled by the user, recommendations section.

Assignee: nobody → maltejur
Attachment #9317238 - Attachment description: WIP: Bug 1808459 - Take `extensions.getAddons.showPane` into consideration when clicking on empty unified extensions button → Bug 1808459 - Take `extensions.getAddons.showPane` into consideration when clicking on empty unified extensions button r?#layout-reviewers
Status: NEW → ASSIGNED
See Also: → 1816386
Blocks: 1778684
Severity: -- → S4
Type: enhancement → defect
Component: Toolbars and Customization → General
Priority: -- → P2
Product: Firefox → WebExtensions
Attachment #9317238 - Attachment description: Bug 1808459 - Take `extensions.getAddons.showPane` into consideration when clicking on empty unified extensions button r?#layout-reviewers → Bug 1808459 - Take `extensions.getAddons.showPane` into consideration when clicking on empty unified extensions button r?#extension-reviewers
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/98a3980955f1
Take `extensions.getAddons.showPane` into consideration when clicking on empty unified extensions button r=extension-reviewers,robwu
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.

The patch landed in nightly and beta is affected.
:maltejur, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(maltejur)

I am not able to change that tag to wontfix

Flags: needinfo?(maltejur)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: