1808459 - Unified Extensions when empty ignores `extensions.getAddons.showPane`

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P2)

Description

[Simon Mainey]

STR

• don't have any extensions in the Unified Extensions panel
• check extensions.getAddons.showPane is deleted (hidden pref)
• click the Unified Extensions button
• it takes you to about:addons > Recommendations = good
• set extensions.getAddons.showPane = false
• click the Unified Extensions button
• it takes you to about:addons > Recommendations = not so good (IMO)

Expected

• it should take you to about:addons > Extensions because enterprises (or users) have disabled recommendations (and/or users have extensions or they are disabled, i.e they are just not in the Unified Extensions panel - hence why to instead land on Extensions - unless you wanted to enumerate extensions and if none land on themes? seems like overkill)

Comment 1

[Malte Jürgens [:mjurgens]]

Attachment: Bug 1808459 - Take `extensions.getAddons.showPane` into consideration when clicking on empty unified extensions button r?#extension-reviewers

In case the user does not have any active extensions listed, if extensions.getAddons.showPane is set to true (default), clicking on the unified extensions button will lead to the recommendations section in about:addons. If it is set to false, clicking the button will now lead to the extension list instead of the, disabled by the user, recommendations section.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98a3980955f1
Take `extensions.getAddons.showPane` into consideration when clicking on empty unified extensions button r=extension-reviewers,robwu

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/98a3980955f1

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:maltejur, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Malte Jürgens [:mjurgens]]

I am not able to change that tag to wontfix