1808603 - Reselect the new top level thread after navigation

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Bug 1770361 regressed getCurrentThread selector.
It is somewhat expected to always return a currently selected thread, but now this can easily be null after navigation.
It isn't clear which particular feature it broke after navigation, but it may have broke anything involved this selector and not handling null values:
https://searchfox.org/mozilla-central/search?q=getCurrentThread&path=debugger%2F&case=false&regexp=false
It looks like most of these callsites are safe thanks to the fact that a thread will be selected as soon as we hit a breakpoint. So anything happening after having paused will be safe.

Nonetheless, the thread is no longer selected in the thread list.
This patch will at least fix this.

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1808603 - [devtools] Fix thread selection on navigation.

This is surprising that no test started failing.
This may have broke various feature after reload.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1770361

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c785da57b1fc
[devtools] Fix thread selection on navigation. r=devtools-reviewers,nchevobbe

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c785da57b1fc