1809168 - Watch expressions don't update on navigations

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

STR:

• add window.location watch expression
• navigate to another URL

The expression doesn't update.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1809168 - [devtools] Update debugger watch expression after page is fully reloaded.

We weren't trying to update the expression around any event related to navigation/reload!
I chose to update them with the latest possible event. navigate/DOCUMENT_EVENT's dom-complete,
which is equivalent to the "load" event.
If we want to update it earlier... we should probably update it more than once per navigation.

Also, I'm tweaking navigateTo test helper to ensure waiting for debugger's reloaded event.
It ensure that all navigate test helper will only resume after the navigated action resolves.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1814613 - [devtools] Avoid firing DOCUMENT_EVENT for previous background page when reloading an add-on.

This can lead to various issues as we were getting two sets of DOCUMENT_EVENT's when reloading an add-on.

Hopefully, this will be simplier to handle once we move WebExtension to EFT
and WindowGlobalTarget will be unique per document and their instantiation is solely
controlled by the watcher codebase.
We might still have to be careful to ignore this spurious about:blank document.

Comment 3

[Phabricator Automation]

Comment on attachment 9314441 [details]
Bug 1814613 - [devtools] Avoid firing DOCUMENT_EVENT for previous background page when reloading an add-on.

Revision D168045 was moved to bug 1814613. Setting attachment 9314441 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f7f098d9af0
[devtools] Update debugger watch expression after page is fully reloaded. r=devtools-reviewers,bomsy

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1814607, Bug 1814608, Bug 1809168) for causing devtools failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=8f7f098d9af03eed0fc6fc4c1e71734e797aa215&searchStr=os%2Cx%2C10.15%2Cwebrender%2Copt%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Ctest-macosx1015-64-qr%2Fopt-mochitest-devtools-chrome-spi-nw%2Cdt1

Log: https://treeherder.mozilla.org/logviewer?job_id=406913328&repo=autoland&lineNumber=2297
https://treeherder.mozilla.org/logviewer?job_id=406914933&repo=autoland&lineNumber=2673

Backout: https://hg.mozilla.org/integration/autoland/rev/219bc96600a47cd4b95ac71b0b378db961481b33

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f960d00b6009
[devtools] Update debugger watch expression after page is fully reloaded. r=devtools-reviewers,bomsy

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f960d00b6009