1808800 - When hovering over bookmarks folders in folders then moving to other bookmarks folders at the top level, the first folders' contents were still shown sometimes in 110.0a1 20230105092304

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Matt Fagnani]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

I started Firefox 110.0a1 20230105092304 on Wayland in Plasma 5.26.4 in a Fedora 37 KDE Plasma installation. I had previously enabled the menu bar. I selected Bookmarks in the menu bar. I moved the cursor over various bookmarks folders and folders in those folders. I moved the cursor over other bookmarks folders at the top level of the bookmarks menu.

Actual results:

When hovering over bookmarks folders in folders then moving to other bookmarks folders at the top level, the first folders' contents were still shown sometimes in 110.0a1 20230105092304. Multiple overlapping bookmarks folders were sometimes shown as a result. This problem also happened with 110.0a1 20230105092304 on XWayland in Plasma and on Wayland and XWayland in GNOME 43.2.

This problem didn't happen with 110.0 2023-1-4 on Wayland in Plasma. I ran mozregression --good 2023-1-4 --bad 2023-1-5 --persist /tmp/mozregression -p ~/.mozilla/firefox/z8d4nvrc.default-nightly

The first bad change was 47c002d3637247e71ee901f32421deaecc9d8ea3 Bug 1805414 - Remove nsMenuFrame and nsMenuParent.

10:24.10 INFO: Narrowed integration regression window from [2ff86d7e, 47c002d3] (3 builds) to [0c989b2b, 47c002d3] (2 builds) (~1 steps left)
10:24.10 INFO: No more integration revisions, bisection finished.
10:24.10 INFO: Last good revision: 0c989b2bcd7882a9e7106e7879ab8933c2e09071
10:24.10 INFO: First bad revision: 47c002d3637247e71ee901f32421deaecc9d8ea3
10:24.10 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0c989b2bcd7882a9e7106e7879ab8933c2e09071&tochange=47c002d3637247e71ee901f32421deaecc9d8ea3

Expected results:

When hovering over bookmarks folders in folders then moving to other bookmarks folders at the top level, the first folders' contents should have disappeared. The second bookmarks folders' contents should have been shown without overlapping with the first menu.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1805414, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Matt Fagnani]

Attachment: A recording of 110.0a1 2023-01-05 showing the problem

I'm attaching a recording of 110.0a1 20230105213109 on Wayland in Plasma 5.26.4 in a Fedora 37 KDE Plasma installation showing a bookmarks folder Firefox Nightly Resources still being shown after moving the cursor over a folder in it. I hovered over the top level Folder 1, Folder 2, and Folder 3 which had their contents shown overlapping that of the Firefox Nightly Resources folder.

Comment 3

[Matt Fagnani]

When I hovered over a bookmark in a folder in a folder and then hovered over another folder in that folder in 110.0a1 20230106214742 on Wayland in Plasma, then the first nested folder's contents were still shown sometimes along with the second folder's contents. The second folder's contents were shown starting from its vertical position which was often lower than usual, so when that folder had many bookmarks/folders it would sometimes be cut off by the bottom of the screen. The folders being cut off at the bottom of the screen might be related to the context menus of bookmarks folders in the lower part of the screen being cut off as I reported in Bug 1792620 which was because non-adjacent popups couldn't use move-to-rect on Wayland.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1808800 - Ensure to activate an ancestor menu if activating a child. r=smaug

This basically implements this chunk of code:

https://hg.mozilla.org/integration/autoland/rev/47c002d3637247e71ee901f32421deaecc9d8ea3#l48.565

In a more reasonable way. This seems rather tricky to test tho, because
this is dependent on the submenu close timer.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd5889a344a9
Ensure to activate an ancestor menu if activating a child. r=smaug

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in toolkit/content/tests/widgets/test_menubar.xhtml

Backout link: https://hg.mozilla.org/integration/autoland/rev/05db4ea9cea48f15d06214f0a7b7e7aaec27459e

Push with failures

Failure log

INFO - TEST-PASS | toolkit/content/tests/widgets/test_menubar.xhtml | cursor down on menu event target ID filepopup 
[task 2023-01-09T08:01:02.026Z] 08:01:02     INFO - Buffered messages finished
[task 2023-01-09T08:01:02.027Z] 08:01:02     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_menubar.xhtml | cursor down on menu event type popupshown fired - got "popupshown", expected "DOMMenuItemActive"
[task 2023-01-09T08:01:02.027Z] 08:01:02     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:487:14
[task 2023-01-09T08:01:02.027Z] 08:01:02     INFO - is@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/popup_shared.js:92:30
[task 2023-01-09T08:01:02.027Z] 08:01:02     INFO - eventOccurred@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/popup_shared.js:154:9
[task 2023-01-09T08:01:02.028Z] 08:01:02     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-01-09T08:01:02.028Z] 08:01:02     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_menubar.xhtml | cursor down on menu event target ID helppopup - got "helppopup", expected "contents"
[task 2023-01-09T08:01:02.029Z] 08:01:02     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:487:14
[task 2023-01-09T08:01:02.029Z] 08:01:02     INFO - is@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/popup_shared.js:92:30
[task 2023-01-09T08:01:02.029Z] 08:01:02     INFO - eventOccurred@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/popup_shared.js:159:9
[task 2023-01-09T08:01:02.030Z] 08:01:02     INFO - TEST-PASS | toolkit/content/tests/widgets/test_menubar.xhtml | cursor down on menu popupshown state

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6600258f7e07
Ensure to activate an ancestor menu if activating a child. r=smaug

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6600258f7e07