1805414 - Remove nsMenuFrame

Status: RESOLVED FIXED

(Firefox :: Menus, task, P1)

Description

[Emilio Cobos Álvarez (:emilio)]

Stop creating legacy layout boxes for menus/menulists/menuitems.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1805414 - Remove nsMenuFrame and nsMenuParent. r=smaug!,jamie!

Move all the event handling stuff to the DOM.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f11c529b2407
Remove nsMenuFrame and nsMenuParent. r=smaug,Jamie,desktop-theme-reviewers,settings-reviewers,dao

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on test_submenuClose.xhtml and nsMenuPopupFrame.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/ff7a5a98e2efc854df61d41aca9056a718c05f0f
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=IlGmPc_hRT2g5BqF0NEToQ.0&revision=f11c529b240799df93c4dd8c17ecd8636f9b10de
• failure logs:
  • TEST-UNEXPECTED-FAIL | layout/xul/test/test_submenuClose.xhtml | Test timed out. -
  • builds/worker/checkouts/gecko/layout/xul/nsMenuPopupFrame.cpp:2042:5: error: unknown type name 'KeyboardEvent'; did you mean 'mozilla::dom::KeyboardEvent'?

Comment 4

[Natalia Csoregi [:nataliaCs]]

Also failing on:

• PROCESS-CRASH | toolkit/content/tests/chrome/test_edit_contextmenu.html | application crashed [@ mozilla::dom::BrowsingContext::CanAccess(mozilla::dom::BrowsingContext*, bool)]
• TEST-UNEXPECTED-FAIL | devtools/client/storage/test/browser_storage_delete_usercontextid.js | Test timed out -

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47c002d36372
Remove nsMenuFrame and nsMenuParent. r=smaug,Jamie,desktop-theme-reviewers,settings-reviewers,dao

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1805414 - Fix test_focus_general.xhtml locally. r=jamie,morgan

This test passes on automation, somehow, probably due to timing.
Locally the click rolls up the popup (so you'd need a second click to
show the other popup).

This happens both with and without the patch, and given I debugged and
it is trivial to fix, well, make sure to hide the previously open menu
before clicking on another...

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b8542b7c655
Fix test_focus_general.xhtml locally. r=morgan

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/47c002d36372

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7b8542b7c655