Closed Bug 1808894 Opened 3 months ago Closed 2 months ago

Update code to check for stale elements based on WebDriver classic PR 1707

Categories

(Remote Protocol :: Marionette, defect, P1)

Product:
Remote Protocol
Component:
Marionette
Version:
Default
Type:
defect
Points:
2

Tracking

(firefox111 fixed)

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 2 open bugs,
URL
)

Details

(Whiteboard: [webdriver:m6][webdriver:relnote])

Attachments

(1 file)

Bug 1808894 - [marionette] Complete (De-)serialization support for WebElement and ShadowRoot.
48 bytes, text/x-phabricator-request
Details | Review

James is currently rewriting the WebDriver classic spec in terms of stale element checks. We have to update our code regarding to these changes.

Especially element.resolveElement() needs to differentiate between WebElement and ShadowRoot.

My proposal would be to include this bug into M6 specifically to the Shadow DOM related work.

Whiteboard: [webdriver:triage]
Severity: -- → S3
Points: --- → 2
Priority: -- → P1
Whiteboard: [webdriver:triage] → [webdriver:m6]
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Duplicate of this bug: 1764594
Blocks: 1744928
Blocks: 1811545
No longer duplicate of this bug: 1764594

The real underlying fix for bug 1764594 has been moved back to bug 1764594 for better tracking.

See Also: https://github.com/mozilla/geckodriver/issues/2006 →
No longer blocks: 1744928
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/75eaaf96d039
[marionette] Complete (De-)serialization support for WebElement and ShadowRoot. r=webdriver-reviewers,jdescottes

It seems this landed with leftover files from a puppeteer install (under remote/test/puppeteer/packages/puppeteer-core/). We might want to backout or followup to cleanup the files?

Flags: needinfo?(hskupin)

Backed out for landing with leftover files from a puppeteer install (under remote/test/puppeteer/packages/puppeteer-core/).

Flags: needinfo?(hskupin)
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a17a55187bdc
[marionette] Complete (De-)serialization support for WebElement and ShadowRoot. r=webdriver-reviewers,jdescottes

https://hg.mozilla.org/mozilla-central/rev/a17a55187bdc

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Product: Testing → Remote Protocol
Whiteboard: [webdriver:m6] → [webdriver:m6][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.