Closed Bug 1809067 Opened 2 years ago Closed 2 years ago

WPT Reftests nth-child-of-no-space-after-of.html and nth-last-child-of-no-space-after-of.html try to match incorrect ref

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox108 --- unaffected
firefox109 --- unaffected
firefox110 --- fixed

People

(Reporter: zrhoffman, Assigned: zrhoffman)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

They try to match ref css/selectors/nth-child-and-nth-last-child-ref.html, but they should match css/selectors/nth-child-of-no-space-after-of-ref.html. I tested the next to last versions of them with expected: PASS (and every version with expected: FAIL, since the matching bug, bug 1808228, is yet unresolved), but really I should have tested every version completely.

The tests for parsing :nth-child(Ab+B of S) and
:nth-last-child(Ab+B of S) when there is no space between "of" and "S"
were trying to match the incorrect ref, but this patch fixes that. They
definitely work now (testing against an early matching implementation).

A few unnecessary lines at the bottom of the file have been removed, as
well.

Set release status flags based on info from the regressing bug 1808227

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bfa8900ca79c Match intended WPT ref in "no space after of" :nth-child(Ab+B of S) reftests r=emilio
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch

ni? for comment 4

Flags: needinfo?(james)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37808 for changes under testing/web-platform/tests
Flags: needinfo?(james)
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: