1809143 - Simplify spotlight.js and related code

Status: RESOLVED INVALID

(Firefox :: Messaging System, task, P1)

Description

[Hanna Alemu [:hanna_a]]

Now that we've removed the legacy spotlight surface (See https://bugzilla.mozilla.org/show_bug.cgi?id=1768730), we can simplify spotlight.js and related files. We can remove some conditionally set variables such as https://searchfox.org/mozilla-central/source/browser/base/content/spotlight.js#156

Comment 1

[Meg Viar [:mviar]]

(In reply to hanna A from comment #0)

Now that we've removed the legacy spotlight surface (See https://bugzilla.mozilla.org/show_bug.cgi?id=1768730), we can simplify spotlight.js and related files. We can remove some conditionally set variables such as https://searchfox.org/mozilla-central/source/browser/base/content/spotlight.js#156

Is the link to the conditionally set variable example above still correct?

Comment 2

[Ed Lee :Mardak]

I think they were referring to these lines (with permalink/fixed revision url):
https://searchfox.org/mozilla-central/rev/cf3af6bb6657278880f8baf38435eeb8f2d5d86c/browser/base/content/spotlight.js#144-152

The original patch comment was here https://phabricator.services.mozilla.com/D165254#inline-916531

Comment 3

[Meg Viar [:mviar]]

Attachment: WIP: Bug 1809143 - Simplify spotlight.js and related code

Comment 4

[Meg Viar [:mviar]]

Thanks :mardak. I'm still unclear on how those lines are affected by the removal of the legacy spotlight.

Comment 5

[Meg Viar [:mviar]]

Closing this bug after discussion with :halamu. Some refinements included in the draft patch may be rolled into bug 1768730.