1768730 - [Cleanup] Remove legacy spotlight messaging surface

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Ed Lee :Mardak]

There's bugs with the legacy spotlight surface such as bug 1766997 and bug 1767606. And it complicates the logic leading to bugs like bug 1767511 or some intermittents for bug 1765907.

We're launching new experiments using the new multistage/about:welcome spotlight surface now, but we do have existing messages wanting to use this such as TCP bug 1740064 targeting 100 and 101 as well as some experiment -> global rollout messages (better-internet-c-rollout-global and peace-of-mind-a-rollout-global from bug 1757830 still live).

Once we're done with those messages and/or converted them to multistage, we should be able to remove the legacy behaviors.

Comment 1

[Hanna Alemu [:hanna_a]]

Attachment: Bug 1768730 - [Cleanup] Remove legacy spotlight messaging surface r=mardak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dcea9f0eb7e
[Cleanup] Remove legacy spotlight messaging surface r=Mardak,fluent-reviewers

Comment 3

[Atila Butkovits]

Backed out for causing python failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/e13683829b0435cd6fd08ce3f742d8bab0447a0d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=c3tWj3s_QKeQ00BiIxh74A.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2dcea9f0eb7e5db8260dc82dc490522dc62de0fc

Failure log: https://treeherder.mozilla.org/logviewer?job_id=401905025&repo=autoland&lineNumber=3540
Bc6 failure: https://treeherder.mozilla.org/logviewer?job_id=401904788&repo=autoland&lineNumber=18613
We also found this: https://treeherder.mozilla.org/logviewer?job_id=401904768&repo=autoland&lineNumber=16753

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7931cc7f97d9
[Cleanup] Remove legacy spotlight messaging surface r=Mardak,fluent-reviewers,barret

Comment 5

[Marian-Vasile Laza]

Backed out changeset 7931cc7f97d9 (Bug 1768730) for causing bc failures on browser_browserGlue_upgradeDialog_trigger.js and browser_aboutwelcome_upgrade_multistage_mr.js.
Backout link
Push with failures <--> bc6 <--> bc8
Failure Log bc6
Failure Log bc8

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69f7e7919ead
[Cleanup] Remove legacy spotlight messaging surface r=Mardak,fluent-reviewers,desktop-theme-reviewers,barret

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/69f7e7919ead