1809162 - Implement dmabuf VA-API surface copy

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Implement dmabuf VA-API surface copy so we don't need to block dmabuf ffmpeg frames recycle.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1809162 [Linux] Implement GetAndConfigureDMABufDevice() to configure dmabuf backend without gfxPlatform on RDD process r?emilio

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1809162 [Linux] Fixed ClaimSnapshotGLContext() logs r?emilio

Depends on D166328

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1809162 [Linux] Implement dmabuf YUV surface copy r?emilio

• Move DMABufSurfaceYUV::CreateYUVPlane to DMABufSurfaceYUV::CreateLinearYUVPlane. That's used for debugging purposes only and may be removed later.
• Implement ImportPRIMESurfaceDescriptor() which files DMABufSurfaceYUV with data from PRIMESurfaceDescriptor except dmabuf file descriptors.
• Implement DMABufSurfaceYUV::CreateYUVPlane(int aPlane) which creates YUV surface plane according to data imported from PRIMESurfaceDescriptor.
• Implement DMABufSurfaceYUV::UpdateYUVDataImpl(). That moves all dmabuf surface data from PRIMESurfaceDescriptor to DMABufSurfaceYUV,
  i.e. DMABufSurfaceYUV and PRIMESurfaceDescriptor points to the same GPU memory.
• Implement DMABufSurfaceYUV::CopyYUVDataImpl(). That copies dmabuf surface from PRIMESurfaceDescriptor to DMABufSurfaceYUV,
  i.e. DMABufSurfaceYUV and PRIMESurfaceDescriptor points to different GPU memory parts with the same content.
• DMABufSurfaceYUV::UpdateYUVData() now takes extra "copy" param to request dmabuf copy.

Depends on D166329

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1809162 [Linux] Add mmedia.ffmpeg.vaapi.zero-copy.enabled and media.ffmpeg.vaapi.zero-copy.force-enabled control VA-API surface copy r?emilio

Depends on D166330

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1809162 [Linux] Utilize dmabuf surface copy in VideoFramePool r?alwu

If we're asked to copy dmabuf surface, don't lock VA-API data. That enables ffmpeg to recycle VA-API surface faster and prevent rendering artifacts on some hardware.

Depends on D166331

Comment 6

[Martin Stránský [:stransky] (ni? me)]

D166328 does only basic config. Bug 1809167 is a follow up to extend it for multiple GPU scenario.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4692e64be33b
[Linux] Implement GetAndConfigureDMABufDevice() to configure dmabuf backend without gfxPlatform on RDD process r=emilio
https://hg.mozilla.org/integration/autoland/rev/84503cda04f3
[Linux] Fixed ClaimSnapshotGLContext() logs r=emilio
https://hg.mozilla.org/integration/autoland/rev/2d88d3f5c01f
[Linux] Implement dmabuf YUV surface copy r=emilio
https://hg.mozilla.org/integration/autoland/rev/bb0ff84365ad
[Linux] Add media.ffmpeg.vaapi.surface-copy.enabled to enable VA-API surface copy r=emilio
https://hg.mozilla.org/integration/autoland/rev/0034c0451d9b
[Linux] Utilize dmabuf surface copy in VideoFramePool r=alwu

Comment 8

[Marian-Vasile Laza]

Backed out 5 changesets (Bug 1809162) for causing bustages on FFmpegVideoFramePool.cpp.
Backout link
Push with failures <--> Bp-hybrid
Failure Log

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1809162 [Linux] Use FEATURE_HW_DECODED_VIDEO_ZERO_COPY to control VA-API surface zero copy on Linux r?alwu,emilio,aosmond

Set FEATURE_HW_DECODED_VIDEO_ZERO_COPY on Linux and enable it for Intel hardware.

Depends on D166332

Comment 10

[Martin Stránský [:stransky] (ni? me)]

I was wrong and surface copy does not fix the rendering artifacts (Bug 1802844), at least from my latest testing.
But we need surface copy for Bug 1809026 - upload dmabuf surfaces as textures to WebGL. WebGL rendering pipeline is too long and causes decoder frame exhaustion without surface copy.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1809162 [Linux] Utilize dmabuf surface copy in VideoFramePool r=alwu

If we're asked to copy dmabuf surface, don't lock VA-API data. That enables ffmpeg to recycle VA-API surface faster and prevent rendering artifacts on some hardware.

Depends on D166330

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82b73378753b
[Linux] Implement GetAndConfigureDMABufDevice() to configure dmabuf backend without gfxPlatform on RDD process r=emilio
https://hg.mozilla.org/integration/autoland/rev/1a21a0a52583
[Linux] Fixed ClaimSnapshotGLContext() logs r=emilio
https://hg.mozilla.org/integration/autoland/rev/1cb0dda1e2c0
[Linux] Implement dmabuf YUV surface copy r=emilio
https://hg.mozilla.org/integration/autoland/rev/a6db25087429
[Linux] Utilize dmabuf surface copy in VideoFramePool

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1809162 [Linux] Type DMABufSurfaceYUV* to RefPtr to avoid build bustage r?CosminS

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0df1e0ac058f
[Linux] Type DMABufSurfaceYUV* to RefPtr to avoid build bustage. a=bustage-fix CLOSED TREE

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/82b73378753b
https://hg.mozilla.org/mozilla-central/rev/1a21a0a52583
https://hg.mozilla.org/mozilla-central/rev/1cb0dda1e2c0
https://hg.mozilla.org/mozilla-central/rev/a6db25087429
https://hg.mozilla.org/mozilla-central/rev/0df1e0ac058f