1811210 - [Linux] Use zero-copy video playback with fallback to surface copy

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

Bug 1809162 switches to video frames copy. Implement zero-copy video playback according to available surfaces.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1811210 [Linux] Enable zero copy for VA-API video playback r?alwu

Implement dynamic frame copy / zero copy during VA-API playback.
Run with zero copy and switch to frame copy when rendering pipeline is slow and vice versa.

Comment 2

[Paul Menzel]

Sounds nice.

Could you share performance numbers without and with the patch?

Comment 3

[Martin Stránský [:stransky] (ni? me)]

(In reply to Paul Menzel from comment #2)

Sounds nice.

Could you share performance numbers without and with the patch?

I don't think it has visible performance benefits. If we copy surfaces we do that on GPU and copied data size may not be significant.
But this is more a stability fix - we do zero copy by default since first VA-API implementation but if there's any problem in rendering queue and we're running out of free ffmpeg frames, we start to copy them ale return to ffmpeg ASAP (instead of HW decode failure). It means the VA-API playback is more robust and avoids switch to SW decode in such case.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

The bug title is a bit misleading - will update it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e856dd24cbd
[Linux] Enable zero copy for VA-API video playback r=alwu

Comment 6

[Paul Menzel]

Thank you so much for the clarification. (Maybe the commit message summary/title could also be updated.) Thank you again for your amazing work.

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8e856dd24cbd