1809488 - The TRR mode3 error page should not add exception when the resolver is not accessible

Status: RESOLVED FIXED

(Firefox :: Security, task, P1)

Description

[Valentin Gosu [:valentin] (he/him)]

If the TRR resolver is not accessible, and we add an exception, it might not help usually.
Additionally, if the page you are loading contains any resources hosted on other domains, it will break in different ways.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1809488 - The TRR mode3 error page should not add exception when the resolver is not accessible r=#necko,acreskey,Gijs

If the error is caused by the TRR server not being accessible (maybe the
network is down) then adding an exception is unlikely to make the load.
Most likely the subsequent page load will also lead to an error page.

However, after connectivity is restored, the exception would remain.
Currently the ability to remove exceptions is lacking a UI.
In the future we might want to replace the exception button with a button
that would exclude the current tab from TRR instead - that way the
exception is not permanent when the failure is caused by a connection
failure to the TRR server.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1809488 - Add test r=#necko,acreskey

Depends on D168077

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fed641dc5ab5
The TRR mode3 error page should not add exception when the resolver is not accessible r=acreskey,Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/feee1997ccf2
Add test r=necko-reviewers,jesup

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing for causing bc failures in browser/base/content/test/about/browser_aboutNetError_trr.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/61ccf9e87d019eb3efa2f9c396e88bb355cf9c3b

Push with failures

Failure log: TEST-UNEXPECTED-FAIL | browser/base/content/test/about/browser_aboutNetError_trr.js | Correct error page title is set - "dnsNotFound-title" == "dns-not-found-trr-only-title" - got "dnsNotFound-title", expected "dns-not-found-trr-only-title" (operator ==)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72fbdf21d978
Add test r=necko-reviewers,jesup

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fed641dc5ab5
https://hg.mozilla.org/mozilla-central/rev/72fbdf21d978