1809713 - Change nsIClipboard constant lists to be a CEnum type

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, task)

Description

[Edgar Chen [:edgar]]

Turn https://searchfox.org/mozilla-central/rev/fb9a504ca73529fa550efe488db2a012a4bf5169/widget/nsIClipboard.idl#26-30 into something like

cenum ClipboardType : 8 {
  kSelectionClipboard = 0,
  kGlobalClipboard = 1,
  kFindClipboard = 2,
  kSelectionCache = 3,
};

Comment 1

[Edgar Chen [:edgar]]

When creating a DataTransfer object, we assign a clipboard type to it, and use that to pass to nsIClipboard. Ideally DataTransfer should use the same type defined in nsIClipboard, but there are some place use -1 as clipboard type to create a DataTransfer, e.g.

• A DataTransfer that is used for drag-and-drop.
• A DataTransfer that is used only internally, e.g. https://searchfox.org/mozilla-central/rev/aec3a901e6f6b3041b5ec457c9111a042cef1fb1/dom/events/Clipboard.cpp#701-703

We need to sort out how to deal with that first.

Comment 2

[Tom Schuster]

Attachment: Bug 1809713 - Make nsIClipboard ClipboardType an enum. r?nika

Comment 3

[Tom Schuster]

We also use an invalid ClipboardType in EditorBase::PasteTransferableAsAction: https://searchfox.org/mozilla-central/rev/b11735b86bb4d416c918e2b2413456561beff50c/editor/libeditor/EditorBase.cpp#1977-1979

    // Use an invalid value for the clipboard type as data comes from
    // aTransferable and we don't currently implement a way to put that in the
    // data transfer in TextEditor yet.

Comment 4

[Tom Schuster]

Attachment: Bug 1809713 - Use ClipboardType in editor. r?masayuki

Comment 5

[Tom Schuster]

Attachment: Bug 1809713 - Make DataTransfer use Maybe<ClipboardType>. r?edgar

Comment 6

[Tom Schuster]

Attachment: WIP: Bug 1809713 - Switch nsIClipboard methods to use ClipboardType

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7f2bc943b32
Make nsIClipboard ClipboardType an enum. r=nika

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f7f2bc943b32

Comment 9

[Tom Schuster]

Attachment: Bug 1809713 - Change nsIClipboard to use the ClipboardType enum. r?nika

Comment 10

[Tom Schuster]

Even with the last patch there are still places where we could use the ClipboardType enum, e.g. in GTK's nsRetrievalContext.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/faacd4575132
Use ClipboardType in editor. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/9fa01e6facf7
Make DataTransfer use Maybe<ClipboardType>. r=edgar
https://hg.mozilla.org/integration/autoland/rev/9cad26af81b2
Change nsIClipboard to use the ClipboardType enum. r=nika,geckoview-reviewers,win-reviewers,gstoll,m_kato

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/faacd4575132
https://hg.mozilla.org/mozilla-central/rev/9fa01e6facf7
https://hg.mozilla.org/mozilla-central/rev/9cad26af81b2