1966621 - Use nsContentPolicyType in IPCInternalRequest IPDL

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P2)

Comment 1

[Tom Schuster]

Attachment: Bug 1966621 - Use nsContentPolicyType in IPCInternalRequest IPDL. r?#necko-reviewers

Comment 2

[Tom Schuster]

There is a question about how to rate this. Casting an out of range enum value is undefined behavior, so it's impossible to say what the compiler does. bug 1902621 is similar and was rated sec-audit as well. Assuming the compiler doesn't decide to blow up the world, the most likely outcome is a skipped CSP check. I think that shouldn't be too concerning. By faking e.g. nsIContentPolicy::TYPE_CSP_REPORT, which is not handled by CSP, it's always possible to skip CSP completely.

Comment 3

[Andrew McCreight [:mccr8]]

Thanks, Tom. I guess I can leave this as audit for consistency but I don't really agree in general with having undefined behavior marked as sec-audit, but I'm not invested enough to figure out why the other bug was marked like that.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4e1602504ff
Use nsContentPolicyType in IPCInternalRequest IPDL. r=necko-reviewers,valentin

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e4e1602504ff