Closed Bug 1809715 Opened 1 year ago Closed 1 year ago

Remove data-l10n-id from the observedAttributes() function in moz-support-link

Categories

(Toolkit :: UI Widgets, task, P3)

task

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: tgiles, Assigned: scolville, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

I can't remember exactly why, but I believed I needed this for the component to behave as expected in Firefox and Storybook. I tested removing the attribute today, thanks to :mossop: for calling this out, and the component still works as expected when the data-l10n-id is changed.

Because of the previous, we should remove the data-l10n-id from the observedAttributes() function for the moz-support-link widget.

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help.
    This will tell others that you're working on the next steps.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions.
  3. Start working on this bug.
    • You will need to remove the "data-l10n-id" from the array in the observedAttribute() function in the moz-support-link widget.
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #fx-desktop-dev channel on Element/Matrix most hours of most days.
  4. Check your changes for adherence to our style guidelines by using mach lint.
  5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
Assignee: nobody → scolville
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f212e3ee4f1
Remove data-l10n-id from observedAttributes() for MozSupportLink r=tgiles
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: