1809798 - Orientation is not respected when loading wallpapers

Status: VERIFIED FIXED

(Firefox for Android :: Homepage, defect, P3)

Description

[Chris Peterson [:cpeterson]]

From github: https://github.com/mozilla-mobile/fenix/issues/27938.

Steps to reproduce

1. Have a wallpaper selected
2. Rotate the device into landscape

Expected behaviour

The landscape version of a wallpaper should be used

Actual behaviour

The landscape version of a wallpaper is never used.

This is because resources.configuration.orientation does not seem to be updated during the orientation change in DefaultLoadBitmapUseCase which can be observed in debug mode. I would guess this is due to HomeActivity manually handling orientation changes. See the line: android:configChanges="keyboard|keyboardHidden|mcc|mnc|orientation|screenSize|layoutDirection|smallestScreenSize|screenLayout" is the Android Manifest for context.

Device name

No response

Android version

Any

Firefox release type

Firefox

Firefox version

Any recent version

Device logs

No response

Additional information

No response

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1809798 - Loads the right wallpaper for the right orientation (#4137)

Comment 3

[twhite]

Duplicate of Bug 1827107?

Comment 4

[BMO Github Automation]

Authored by https://github.com/RebecaTudor
https://github.com/mozilla-mobile/firefox-android/commit/1d177e7e78d027e8ab32cedf0fc68316787d7454
[main] Bug 1809798 - Loads the right wallpaper for the right orientation

Comment 5

[Rebeca Tudor]

This fix resolved the problem for android versions <=12. For android 13+, this issue was described in a new ticket Bug 1875803.

Comment 6

[Lorand Janos]

This issue seems to be fixed when testing on phone: Redmi 9C NFC (Android 10).
However using a tablet the orientation doesn't seem to be respected when turning from portrait to landscape the first time.
Tested tablet: Redmi Pad SE (Android 12).
Tested build: Nightly 124.0a1 (from 2024-01-23).
For the above mentioned reason, I will reopen the ticket.

Comment 7

[Lorand Janos]

Attachment: Recorder_23012024_163248.mp4

Comment 8

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1809798 - Loads the right wallpaper when changing orientation (#5387)

Comment 9

[BMO Github Automation]

Authored by https://github.com/RebecaTudor
https://github.com/mozilla-mobile/firefox-android/commit/3d759e344795e5c8fe536ef511f9c2045f563b73
[main] Bug 1809798 - Loads the right wallpaper when changing orientation

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:rebecatudor273, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Delia Pop (Android QA)]

Attachment: screen-20240206-151952.mp4

Verified as fixed on latest Nightly 124.0a1 from 02/06. The wallpaper is correctly displayed when changing the orientation.
Tested with:

• Lenovo Yoga Tab 11 (Android 12)
• Huawei MediaPad M2 (Android 5.1.1)
• Samsung Galaxy S22 Ultra (Android 14)
• OPPO A15s (Android 10)
• LG G7 fit (Android 8.1.0)

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Should we uplift this for 123?

Comment 14

[Jeff Boek [:boek]]

Since there was a regression in the first fix let's let this one bake. I don't think there is a rush to release this one.