1810005 - Add tests for DoH native fallback warning page

Status: RESOLVED FIXED

(Firefox :: Security, enhancement)

Description

[Andrew Creskey [:acreskey]]

In Bug 1806412 we are introducing a new warning page to be shown when DoH fails and we are about to fallback to native name resolution.
(This functionality is disabled behind a pref).

As with the new TRR Mode 3 warning, Bug 1806258, we will need tests to cover this feature.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Security' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Andrew Creskey [:acreskey]]

Attachment: Bug 1810005 - Add tests for DoH native fallback warning page r=#necko-reviewers

These tests add partial coverage to the native fallback warning added in Bug 1806412.

Comment 3

[Andrew Creskey [:acreskey]]

Attachment: Bug 1810005 - Don't force a run of heuristics on native fallback pref changes r=#necko-reviewers

Calling MaybeRunHeuristics is sufficienct because there are other reasons why we may not want to run heuristics.

Depends on D169254

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8166a8860490
Add tests for DoH native fallback warning page r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/8857544d30d7
Don't force a run of heuristics on native fallback pref changes r=necko-reviewers,valentin

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8166a8860490
https://hg.mozilla.org/mozilla-central/rev/8857544d30d7