1810047 - Implement extension runtime permissions Dialog in AC

Status: VERIFIED FIXED

(Fenix :: WebExtensions, task, P3)

Description

[Chris Peterson [:cpeterson]]

From github: https://github.com/mozilla-mobile/fenix/issues/16912.

Steps to reproduce

1. Go to Settings of an extension with runtime permission request (should be options.html on desktop)
2. Let the extionsion request runtime permissions. Say, click Grant permission in the Settings page

Expected behavior

A popup is shown to grant/deny the runtime permission request

Actual behavior

Nothing happens.

Device information

• Android device: Android 10
• Fenix version: Nightly 201207 17:01 (Build #2015780043)

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[Chris Peterson [:cpeterson]]

Cathy says:

The geckoview work to implement permissions.request has been completed. Fenix can now implement the new delegate method onOptionalPrompt.
Related patch: https://phabricator.services.mozilla.com/D143925
Related geckoview bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1601420

https://github.com/mozilla-mobile/fenix/issues/16912#issuecomment-1117508957

Comment 2

[Arturo Mejia [:amejia]]

Adding extra documentation:

• Optional permission API
• How to request extension permissions at run-time

Comment 3

[Arturo Mejia [:amejia]]

We did a similar implementation for normal prompt dialogs (Like alert or confirm) that website could requests, see GeckoPromptDelegate for references.

Comment 4

[Arturo Mejia [:amejia]]

When implementing this API we have to take into consideration Android permission that could be needed to access the APIs, like geolocation must have access to the location permission.

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1810047 - Implement UI for webextensions optional permissions. (#3917)

Comment 8

[BMO Github Automation]

Authored by https://github.com/willdurand
https://github.com/mozilla-mobile/firefox-android/commit/23d86211efdbbdefcf40f67e71495265fbb9cfb6
[main] Bug 1810047 - Implement UI for webextensions optional permissions.

Comment 9

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1810047 - Fixup WebExtensionPromptFeature (#3949)

Comment 10

[BMO Github Automation]

Authored by https://github.com/willdurand
https://github.com/mozilla-mobile/firefox-android/commit/c108c3b4113ca12c9700b4a31da0057670f3b589
[main] Bug 1810047 - Fixup WebExtensionPromptFeature

Comment 11

[William Durand [:willdurand]]

We should mark the WebExtensions API (permissions.request()) as compatible with Firefox Android 120 now.

Comment 12

[Alex Cornestean]

Verified as Fixed. Tested on the latest Fenix Nightly 120.0a1 (Build #2015979426), 76b8895043+, in both Light/Dark and Portrait/Landscape modes, using an Oppo Reno6 5G running Android 13.

Using the STR from Bug 1858057, an optional permission dialogue is displayed on the Settings page of the add-on when the user checks the box for the optional permission.

See the attached screenshot for more details.

Comment 13

[Alex Cornestean]

Attachment: 1697094748838.JPEG

Comment 14

[rbloor]

We should mark the WebExtensions API (permissions.request()) as compatible with Firefox Android 120 now.

Completed in https://github.com/mdn/browser-compat-data/pull/21846