1810631 - Display name instead of e-mail in menu

Status: VERIFIED FIXED

(Fenix :: Accounts and Sync, enhancement)

Description

[Jonathan Almeida [:jonalmeida]]

From github: https://github.com/mozilla-mobile/fenix/issues/20974.

I'm on Firefox 91.3.0 on Android 11.

Please add option to display "display name" instead of e-mail address in menu when user is signed to sync.

Currently e-mail address is exposed.

This change will benefit people interested in privacy.

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1810631 - Display name instead of e-mail in menu (#920)

Comment 2

[Chris Peterson [:cpeterson]]

No need to uplift to 110, but maybe consider for a 111 dot release.

Comment 3

[Lorand Janos]

Verified as fixed on the latest Nightly 112.0a1 (2023-03-06).
Devices used:

• Google Pixel 7 (Android 13).
• Samsung Galaxy Tab S3 (Android 9).
• LG Nexus 5 (Android 6.0.1).

Marking the ticket as verified for 112.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Agree that this is a small patch that can be uplifted. Will prepare an uplift PR.

Comment 5

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1810631 - Display name instead of e-mail in menu (backport #920) (#1125)

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9321297 [details] [review]
[mozilla-mobile/firefox-android] Bug 1810631 - Display name instead of e-mail in menu (backport #920) (#1125)

Beta/Release Uplift Approval Request

• User impact if declined: Users would see the email instead of the username of their Firefox account in the 3dot menu.
  This change comes to unify the behavior on all platforms.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - be signed in into a Firefox account

• tap the 3dot menu and check the sync item

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change verified in Nightly by QA.
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9321297 [details] [review]
[mozilla-mobile/firefox-android] Bug 1810631 - Display name instead of e-mail in menu (backport #920) (#1125)

Moving beta uplift request to release uplift request.
We are now in 111 RC week, this can be considered for inclusion in a 111 dot release

Comment 8

[Delia Pop]

Attachment: Account_Name.png

Tested on Nightly 113.0a1 from 15/03 and Beta 112.0b2 with Samsung Galaxy A53 5G (Android 13) and Google Pixel 6 (Android 13).
If available, the account name is displayed throughout the menus.

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9321297 [details] [review]
[mozilla-mobile/firefox-android] Bug 1810631 - Display name instead of e-mail in menu (backport #920) (#1125)

Approved for Fenix 111.1.1

Comment 10

[BMO Github Automation]

Authored by https://github.com/gitstart
https://github.com/mozilla-mobile/firefox-android/commit/6ddd50e04b3552d580fa3fc603a71b048b8e3601
[releases_v111] Bug 1810631 - Display name instead of e-mail in menu (#920)

Comment 11

[Lorand Janos]

Verified as fixed on the latest RC111.1.1 build.
Devices used:

• LG Nexus 5 (Android 6.0.1).
• Samsung Galaxy Tab S3 (Android 9).
• Oppo Find X3 Neo (Android 11).
• Google Pixel 7 (Android 13).
• Samsung Galaxy Tab A7 (Android 13).

Marking the ticket as verified for 111 as well.