1810810 - open the password manager with the current site preselected

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement, P3)

Description

[Pomax]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

Open the "Passwords" UI from the hamburger menu, while on a website.

Actual results:

The password manager opens with an entry preselected, but that entry is "the first entry in the list", so even though I'm on google.com, and have password entries for google.com, the password manager goes "you clearly wanted to see what you have saved for 127.0.0.1:8000".

Expected results:

The password manager, when opened from the hamburger menu, with an obvious website already open in the currently active tab, should find the entry for the currently open website and show that.

Or, if there are no entries for the tab's website, it should show "you have no saved passwords for blah.example.org, you can find your saved passwords on the left" instead of just blindly opening the first (completely unrelated) entry in the list.

Comment 1

[Issam Mani [:issammani]]

Attachment: Bug 1810810 - Preselect login item for referring site. r=#credential-management-reviewers!

Comment 2

[Sergey Galich [:serg]]

Potentially a duplicate of Bug 1756498

Comment 3

[Pomax]

Sounds like it might be; I would recommend folding that one into this one instead, as someone's now working on this bug.

Comment 4

[Issam Mani [:issammani]]

Attachment: Bug 1810810 - Add test for login preselection. r=mtigley!

Depends on D167259

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35e737d45fd9
Preselect login item for referring site. r=credential-management-reviewers,desktop-theme-reviewers,dao,mtigley
https://hg.mozilla.org/integration/autoland/rev/400477da817c
Add test for login preselection. r=mtigley,credential-management-reviewers

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/35e737d45fd9
https://hg.mozilla.org/mozilla-central/rev/400477da817c