1810961 - Window buttons (min/max/close) not visible in Win 10's dark mode

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Julius B.]

Attachment: 2023-01-18 11_17_11-Inbox-Mozilla Thunderbird.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36 Edg/109.0.1518.52

Steps to reproduce:

• Change Windows 10 theme to "Dark" color mode, and enable accent color for title bars and window borders
• Start Thunderbird Beta with a clean profile
• Observe the window buttons

Actual results:

• They are drawn in black on a very dark grey title bar, making them barely visible

Expected results:

• They are drawn in white, just like in Firefox

Comment 1

[Julius B.]

Attachment: Windows 10 color settings (1)

Comment 2

[Julius B.]

Attachment: Windows 10 color settings (2)

Comment 3

[Thomas D. (:thomas8)]

Confirming based on screenshot of comment 0.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Bug 1810961 - Don't set the AccentColorText on the titlebar with dark system theme. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

This happens on Windows 11 too and TB 102. To see the bug you need to select a light Accent colour.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b6219a0af701
Don't set the AccentColorText on the titlebar with dark system theme. r=aleca

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9312853 [details]
Bug 1810961 - Don't set the AccentColorText on the titlebar with dark system theme. r=aleca

[Approval Request Comment]
User impact if declined: On Windows with dark theme and light accent color almost invisible caption buttons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1810961-accentColor-ESR.patch

[Approval Request Comment]
User impact if declined: On Windows with dark theme and light accent color almost invisible caption buttons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9312853 [details]
Bug 1810961 - Don't set the AccentColorText on the titlebar with dark system theme. r=aleca

[Triage Comment]
Approved for beta

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 110.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/287fbdcf8f37

Comment 11

[Julius B.]

I can confirm that the issue is fixed in Thunderbird 110.0b2, for both active and inactive windows. Thanks for the quick fix!

Comment 12

[Julius B.]

Attachment: Fixed in Thunderbird 110.0b2

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9313070 [details] [diff] [review]
1810961-accentColor-ESR.patch

[Triage Comment]
approved for esr102
(nice that it is confirmed fixed on beta)

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 102.7.1:
https://hg.mozilla.org/releases/comm-esr102/rev/858cae600db1