1810985 - Perma iscript.exceptions.IScriptError: /builds/scriptworker/work/cot/a4L110iWQviOArIjqOWLqg/public/build/ja-JP-mac/target.langpack.xpi is not a valid langpack

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nerli [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=402759202&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IhCaeYnySS-skdWfv9WE2g/runs/0/artifacts/public/logs/live_backing.log

---

2023-01-18 12:15:15,807 - scriptworker_client.client - DEBUG - Task is verified against this schema: {'title': 'Taskcluster signing task minimal schema', 'type': 'object', 'properties': {'dependencies': {'type': 'array', 'minItems': 1, 'uniqueItems': True, 'items': {'type': 'string'}}, 'scopes': {'type': 'array', 'minItems': 1, 'uniqueItems': True, 'items': {'type': 'string'}}, 'payload': {'type': 'object', 'properties': {'upstreamArtifacts': {'type': 'array', 'items': {'type': 'object', 'properties': {'taskType': {'type': 'string'}, 'taskId': {'type': 'string'}, 'formats': {'type': 'array', 'uniqueItems': True, 'items': {'type': 'string', 'enum': ['macapp', 'widevine', 'omnija', 'autograph_widevine', 'autograph_omnija', 'mac_geckodriver', 'mac_single_file', 'autograph_langpack']}}, 'paths': {'type': 'array', 'minItems': 1, 'uniqueItems': True, 'items': {'type': 'string'}}}, 'singleFileGlobs': {'type': 'array', 'uniqueItems': True, 'items': {'type': 'string'}}, 'required': ['taskId', 'taskType', 'paths']}, 'minItems': 1, 'uniqueItems': True}, 'behavior': {'type': 'string', 'enum': ['mac_notarize', 'mac_geckodriver', 'mac_sign', 'mac_sign_and_pkg', 'mac_notarize_part_1', 'mac_notarize_part_3', 'mac_single_file', 'mac_notarize_vpn', 'mac_notarize_single_file', 'mac_notarize_geckodriver']}, 'product': {'type': 'string', 'enum': ['firefox', 'mozillavpn']}, 'entitlements-url': {'type': 'string'}, 'provisioning-profile-url': {'type': 'string'}, 'requirements-plist-url': {'type': 'string'}}, 'required': ['upstreamArtifacts']}}, 'required': ['scopes', 'payload']}
2023-01-18 12:15:15,816 - asyncio - DEBUG - Using selector: KqueueSelector
2023-01-18 12:15:15,816 - scriptworker_client.utils - INFO - Running ['hostname'] in / ...
2023-01-18 12:15:15,824 - scriptworker_client.utils - INFO - mac-v3-signing2.srv.releng.mdc1.mozilla.com
2023-01-18 12:15:15,824 - scriptworker_client.utils - INFO - ['hostname'] in / exited 0
2023-01-18 12:15:15,825 - scriptworker_client.aio - INFO - Downloading https://hg.mozilla.org/mozilla-central/raw-file/60b4965aa0ca5a7a60c71229600092a65df8bc1d/security/mac/hardenedruntime/production.entitlements.xml
2023-01-18 12:15:16,494 - scriptworker_client.utils - DEBUG - makedirs(/builds/scriptworker/work)
2023-01-18 12:15:16,538 - scriptworker_client.aio - INFO - Done
2023-01-18 12:15:16,539 - scriptworker_client.aio - INFO - Downloading https://hg.mozilla.org/mozilla-central/raw-file/60b4965aa0ca5a7a60c71229600092a65df8bc1d/build/package/mac_osx/requirements.plist
2023-01-18 12:15:17,261 - scriptworker_client.utils - DEBUG - makedirs(/builds/scriptworker/work)
2023-01-18 12:15:17,302 - scriptworker_client.aio - INFO - Done
2023-01-18 12:15:17,305 - scriptworker_client.client - ERROR - Failed to run async_main; exiting 1
Traceback (most recent call last):
  File "/builds/scriptworker/virtualenv/lib/python3.8/site-packages/scriptworker_client-1.0.0-py3.8.egg/scriptworker_client/client.py", line 182, in _handle_asyncio_loop
    await async_main(config, task)
  File "/builds/scriptworker/virtualenv/lib/python3.8/site-packages/iscript-1.0.1-py3.8.egg/iscript/script.py", line 98, in async_main
    await func(config, task, **args)
  File "/builds/scriptworker/virtualenv/lib/python3.8/site-packages/iscript-1.0.1-py3.8.egg/iscript/mac.py", line 1231, in notarize_1_behavior
    await sign_langpacks(config, sign_config, langpack_apps)
  File "/builds/scriptworker/virtualenv/lib/python3.8/site-packages/iscript-1.0.1-py3.8.egg/iscript/autograph.py", line 491, in sign_langpacks
    id = langpack_id(app)
  File "/builds/scriptworker/virtualenv/lib/python3.8/site-packages/iscript-1.0.1-py3.8.egg/iscript/autograph.py", line 473, in langpack_id
    raise IScriptError(f"{app.orig_path} is not a valid langpack")
iscript.exceptions.IScriptError: /builds/scriptworker/work/cot/a4L110iWQviOArIjqOWLqg/public/build/ja-JP-mac/target.langpack.xpi is not a valid langpack
exit code: 1

Comment 1

[Julien Cristau [:jcristau]]

Regressed by bug 1810734, iscript's expectations for langpack manifests need to be updated. Please back out the regressing change in the mean time.

Comment 2

[Noemi Erli[:noemi_erli]]

Sure, does it require a new Nightly asap? Or I can do the backout from autoland?

Comment 3

[Julien Cristau [:jcristau]]

autoland should be fine.

Comment 4

[Julien Cristau [:jcristau]]

Will, can you help us update https://github.com/mozilla-releng/scriptworker-scripts/blob/0fa1444ab18f3a5010c68aeaa0d58305309e0eca/iscript/src/iscript/autograph.py#L465-L471?

Comment 5

[Johan Lorenzo [:jlorenzo]]

For the record, it should be a matter of updating the workers in charge of notarizing Apple content. At the moment, it sanity-checks the manifest this way[1].

[1] https://github.com/mozilla-releng/scriptworker-scripts/blob/0fa1444ab18f3a5010c68aeaa0d58305309e0eca/iscript/src/iscript/autograph.py#L465-L473

Comment 6

[Julien Cristau [:jcristau]]

Note for whoever ends up working on this, https://github.com/mozilla-releng/scriptworker-scripts/pull/549 fixed a similar issue in signingscript.

Comment 7

[William Durand [:willdurand]]

I submitted a patch, see: https://github.com/mozilla-releng/scriptworker-scripts/pull/619 - I am waiting on CI to see what breaks since I haven't found how to run the tests locally yet.. Anyway sorry about that!

Comment 8

[Julien Cristau [:jcristau]]

Attachment: [scriptworker-scripts #619] Add better support for browser_specific_settings (with applications as fallback)

Comment 9

[Cosmin Sabou [:CosminS]]

Regressing bug was backed out and merged to central: https://bugzilla.mozilla.org/show_bug.cgi?id=1810734#c5

Comment 10

[William Durand [:willdurand]]

Attachment: GitHub Pull Request

FTR: we had to make some changes in the following repo too: https://github.com/mozilla-platform-ops/ronin_puppet

Comment 11

[Intermittent Failures Robot]

3 failures in 3717 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 3

Platform and build breakdown:

• osx-shippable: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1810985&startday=2023-01-16&endday=2023-01-22&tree=all

Comment 12

[William Durand [:willdurand]]

I think we can close this bug now.